ci: add GitHub Actions workflows (tests, continuous release, release) - #2
Merged
Conversation
Ports the workflow setup from solidjs/solid-image: - tests.yml: build, test, and `npm pack --dry-run` on PRs and main - cr.yml: pkg-pr-new preview releases - release.yml: changesets release PR / npm publish, with `id-token: write` so npm trusted publishing can be pointed at this workflow Adds the two things the workflows depend on: an .nvmrc (24.15.0) for `setup-node`'s node-version-file, and a `packageManager` field so `pnpm/action-setup@v4` can resolve the pnpm version. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
birkskyum
approved these changes
Jul 31, 2026
pkg-pr-new requires its GitHub App to be installed on the repository; without it the /check call 404s with "There is no workflow defined for <id>" and the job fails. Installing the app needs org admin, so pull the workflow out for now and restore it once the app is in place. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the workflow setup from solidjs/solid-image.
Workflows
tests.yml— build, test, andnpm pack --dry-runon PRs and pushes tomain.cr.yml—pkg-pr-newpreview releases for every PR / push.release.yml— changesets: opens a release PR, or publishes to npm once that PR merges. Declaresid-token: writeso npm trusted publishing can be pointed at this workflow.Supporting changes
Two things these workflows depend on that the repo didn't have yet:
.nvmrc(24.15.0, matching solid-image) —actions/setup-nodeis configured withnode-version-file.packageManager: pnpm@11.1.1inpackage.json—pnpm/action-setup@v4is used without aversioninput, so it resolves the pnpm version from this field. Pinned to the version already in use locally so--frozen-lockfilestays happy.Follow-up after merge
Configure the trusted publisher for
filesystem-routingon npmjs.com to point at reposolidjs/filesystem-routing, workflow filerelease.yml. Notes:NPM_TOKEN/NODE_AUTH_TOKENsecret should be set — changesets 2.31.1 skips its OTP/auth check when stdin isn't a TTY, so it goes straight tonpm publishand npm's OIDC exchange takes over.There are two unreleased changesets in
.changeset/, so the first push tomainafter this merges will open a release PR rather than publish directly.Verification
Ran locally — every command the workflows invoke succeeds:
pnpm build✅pnpm test✅ 71 tests passingnpm pack --dry-run✅ 30 files, 27.0 kB🤖 Generated with Claude Code