Merged
Conversation
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amirhhashemi
commented
Mar 16, 2025
amirhhashemi
commented
Mar 16, 2025
amirhhashemi
force-pushed
the
fix-build-errors
branch
from
221651c to
bfd6527
Compare
LadyBluenotes
approved these changes
Mar 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description(required)
The builds have been failing for a while. I'm not sure what the problem was, this PR seems to fix it. It includes a bunch of refactors too. I created an "install" action that abstracts the jobs installing with pnpm.
You might want to merge #1129 before this one so the type error gets resolved and we can make sure it fixes the build errors.