Fix: Infer useRouteData return type for nested routeData#1002
Merged
ryansolid merged 1 commit intosolidjs:mainfrom Aug 16, 2023
Merged
Fix: Infer useRouteData return type for nested routeData#1002ryansolid merged 1 commit intosolidjs:mainfrom
ryansolid merged 1 commit intosolidjs:mainfrom
Conversation
rempartIrien
added a commit
to rempartIrien/easy-gundam
that referenced
this pull request
Sep 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
See #982 the 2nd issue.
What is the new behavior?
I made adjustments to the
useRouteDataoverload in line with theRouteDataFuncreturn type inference first added by otonashi hereThis restores the ability to correctly infer nested routeData type. However, this seems only to work when using the type
RouteDataFuncArgsinstead ofRouteDataArgs. I am not sure if there are breaking side-effects, it only fixes this specific issue. I have added an example to the stackblitz mentioned in the issue.This might not be the desired solution but I consider it a first step.