-
Notifications
You must be signed in to change notification settings - Fork 405
feat: add with solidbase example #1847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
More templates
commit: |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I get this for some reason, on ➜ Local: http://localhost:4000/
➜ Network: use --host to expose
✘ [ERROR] Could not resolve "../pkg"
../node_modules/.pnpm/lightningcss@1.29.1/node_modules/lightningcss/node/index.js:16:27:
16 │ module.exports = require(`../pkg`);
╵ ~~~~~~~~
✘ [ERROR] Could not resolve "../pkg"
../node_modules/.pnpm/lightningcss@1.29.1/node_modules/lightningcss/node/index.js:16:27:
16 │ module.exports = require(`../pkg`);
╵ ~~~~~~~~
✘ [ERROR] Could not resolve "../pkg"
../node_modules/.pnpm/lightningcss@1.29.1/node_modules/lightningcss/node/index.js:16:27:
16 │ module.exports = require(`../pkg`);
╵ ~~~~~~~~
/Users/admin/repos/solid-start/examples/node_modules/.pnpm/esbuild@0.24.2/node_modules/esbuild/lib/main.js:1476
let error = new Error(text);
^ |
|
It's best to remove the lockfile. There's a lockfile in the /examples folder that cover all of the examples. |
No, SolidBase doesn't use |
|
I still have this lightningcss issue in dev, which i don't experience in other examples, like the with-tailwindcss. The prod build works great though. |
|
No idea why Using |
|
Further testing the error only happens when the folder |
|
SolidBase doesn't currently work with lightningcss created issue kobaltedev/solidbase#59. @birkskyum is running dev inside the example folder a blocker? It's only meant to be used for template install via the cli. |
Okay, let's see if we can resolve it that way |
Adds an example with SolidBase for the CLI.