Skip to content

Conversation

@jer3m01
Copy link
Member

@jer3m01 jer3m01 commented Mar 8, 2025

Adds an example with SolidBase for the CLI.

@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2025

⚠️ No Changeset found

Latest commit: a82f6d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 8, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit a82f6d1
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/683337d60edb240008c98616
😎 Deploy Preview https://deploy-preview-1847--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jer3m01 jer3m01 requested a review from birkskyum March 8, 2025 00:55
@birkskyum
Copy link
Member

I get this for some reason, on pnpm dev. Have you seen that before?

   Local:    http://localhost:4000/
   Network:  use --host to expose

 [ERROR] Could not resolve "../pkg"

    ../node_modules/.pnpm/lightningcss@1.29.1/node_modules/lightningcss/node/index.js:16:27:
      16    module.exports = require(`../pkg`);
                                     ~~~~~~~~

 [ERROR] Could not resolve "../pkg"

    ../node_modules/.pnpm/lightningcss@1.29.1/node_modules/lightningcss/node/index.js:16:27:
      16    module.exports = require(`../pkg`);
                                     ~~~~~~~~

 [ERROR] Could not resolve "../pkg"

    ../node_modules/.pnpm/lightningcss@1.29.1/node_modules/lightningcss/node/index.js:16:27:
      16    module.exports = require(`../pkg`);
                                     ~~~~~~~~

/Users/admin/repos/solid-start/examples/node_modules/.pnpm/esbuild@0.24.2/node_modules/esbuild/lib/main.js:1476
  let error = new Error(text);
              ^

@birkskyum
Copy link
Member

It's best to remove the lockfile. There's a lockfile in the /examples folder that cover all of the examples.

@jer3m01
Copy link
Member Author

jer3m01 commented Mar 8, 2025

I get this for some reason, on pnpm dev. Have you seen that before?

No, SolidBase doesn't use lightningcss either, I'll check if it still happens on main.

@birkskyum
Copy link
Member

birkskyum commented Mar 8, 2025

I still have this lightningcss issue in dev, which i don't experience in other examples, like the with-tailwindcss.

The prod build works great though.

@jer3m01
Copy link
Member Author

jer3m01 commented Mar 8, 2025

No idea why lightningcss is even installed, pnpm why lightningcss --exclude-peers in the solidbase example folder doesn't return anything.

Using pnpm@10 rather than 9 fixes the problem.

@jer3m01
Copy link
Member Author

jer3m01 commented Mar 8, 2025

Further testing the error only happens when the folder with-solidbase is within the solid-start repo.
The workspace is somehow breaking it.

@jer3m01
Copy link
Member Author

jer3m01 commented Mar 9, 2025

SolidBase doesn't currently work with lightningcss created issue kobaltedev/solidbase#59.

@birkskyum is running dev inside the example folder a blocker? It's only meant to be used for template install via the cli.

@birkskyum birkskyum mentioned this pull request Mar 9, 2025
@birkskyum
Copy link
Member

birkskyum commented Mar 9, 2025

Using pnpm@10 rather than 9 fixes the problem.

Okay, let's see if we can resolve it that way

@birkskyum birkskyum merged commit f4052b2 into main May 30, 2025
10 checks passed
@birkskyum birkskyum deleted the feat/solidbase branch May 30, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants