Skip to content

feat: add option to change public directory#1921

Merged
atilafassina merged 5 commits intosolidjs:mainfrom
huseeiin:add-public-dir-option
Aug 5, 2025
Merged

feat: add option to change public directory#1921
atilafassina merged 5 commits intosolidjs:mainfrom
huseeiin:add-public-dir-option

Conversation

@huseeiin
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Addresses an existing open issue: fixes #000
  • Tests for the changes have been added (for bug fixes / features)

What is the current behavior?

What is the new behavior?

add the option to change the public directory path (default: "public").

Other information

requested by a member on the solidjs discord: https://discord.com/channels/722131463138705510/910635844119982080/1390847703323508767

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 11, 2025

🦋 Changeset detected

Latest commit: 9832e88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/start Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 11, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 9832e88
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/688d54006e3094000807392f
😎 Deploy Preview https://deploy-preview-1921--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jul 11, 2025

Copy link
Copy Markdown
Contributor

@brenelz brenelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Copy Markdown

@Eliot00 Eliot00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atilafassina atilafassina merged commit b454563 into solidjs:main Aug 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants