Skip to content

chore: Updated with-auth example#1928

Merged
atilafassina merged 6 commits intosolidjs:mainfrom
thomasbuilds:main
Aug 5, 2025
Merged

chore: Updated with-auth example#1928
atilafassina merged 6 commits intosolidjs:mainfrom
thomasbuilds:main

Conversation

@thomasbuilds
Copy link
Copy Markdown
Contributor

Summary

This PR enhances the with-auth example by introducing context-based session management for simpler integration with Vinxi sessions. It also adds start-oauth package for seamless OAuth flows, expanding beyond the existing (and non-production-ready btw) email/password flow.

To improve the user experience, TailwindCSS has been added alongside UI updates and a missing About page has been added too. The example still leverages unstorage for database-backed user management and keeps most of the existing logic.

Key Improvements

  • Global Session Context – Centralized session access for cleaner and more maintainable code.
  • OAuth Integration – Added start-oauth with sign in with discord
  • UI/UX Enhancements – TailwindCSS styling and refined components.
  • Example Expansion – Added the missing About page and improved structure.

Motivation

These changes make the example more realistic by showcasing context-driven session handling, OAuth integration, and improved design for better clarity and usability.

Screenshot

Updated /login UI: Screenshot from 2025-07-29 14-35-11

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 29, 2025

⚠️ No Changeset found

Latest commit: fb1aa49

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 29, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit fb1aa49
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/689210b5b186f10008acd9ef
😎 Deploy Preview https://deploy-preview-1928--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jul 29, 2025

Copy link
Copy Markdown
Member

@atilafassina atilafassina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 tiny nits that can potentially prevent some edge-case issues. But the PR is in great shape as it is. Thank you very much! 🏆

Comment thread examples/with-auth/src/components/Nav.tsx Outdated
Comment thread examples/with-auth/src/lib/index.ts Outdated
@atilafassina atilafassina merged commit 5568611 into solidjs:main Aug 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants