Update server-functions-plugin and cleanup server functions #2005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Deploy Preview for solid-start-landing-page failed. Why did it fail? →
|
commit: |
katywings
force-pushed
the
devinxi-update-tanstack-server-fn
branch
from
502a2ab to
6f6293d
Compare
katywings
changed the title
katywings
changed the title
TanStack Server Functions already encodes the name into the function id: https://github.com/TanStack/router/blob/40b7576ff89d549af1218a1925c7cfaf9e85d724/packages/server-functions-plugin/src/index.ts#L111 Refs: #1859, #1872
katywings
force-pushed
the
devinxi-update-tanstack-server-fn
branch
from
6f6293d to
46bf8c3
Compare
brenelz
reviewed
Nov 19, 2025
| }, | ||
| server: { | ||
| directive: "use server", | ||
| callers: [ |
Contributor
There was a problem hiding this comment.
oh this completely changed did it?
brenelz
reviewed
Nov 19, 2025
| )}'`, | ||
| replacer: (opts) => | ||
| `createServerReference(${opts.fn}, '${opts.functionId}', '${opts.extractedFilename}')`, | ||
| `createServerReference(${opts.fn}, '${opts.functionId}')`, |
Contributor
There was a problem hiding this comment.
the filename wasn't doing much anyways was it?
atilafassina
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
@tanstack/server-functions-pluginisn't strictly pinned to a version.@tanstack/server-functions-pluginconfig is broken.Server function API's are imported via relative paths.What is the new behavior?
@tanstack/server-functions-pluginis now strictly pinned, because TanStack is still in prerelease mode (no semver).Server function API's are imported via package.json exports.(resulted inCannot read properties of undefined (reading 'SERVER_BASE_URL')with actual (non-monorepo) projects.Other information
'use server'will cause an error when there is Chinese in the file path #1859