Skip to content

Conversation

@atilafassina
Copy link
Member

make sure the types we export are consumable and accurate

@changeset-bot
Copy link

changeset-bot bot commented Nov 23, 2025

⚠️ No Changeset found

Latest commit: ec65422

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Nov 23, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit ec65422
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/692341eb7f47cd000846d69b
😎 Deploy Preview https://deploy-preview-2014--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 23, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@2014

commit: ec65422

@atilafassina atilafassina requested a review from Copilot November 23, 2025 15:33
@atilafassina atilafassina self-assigned this Nov 23, 2025
@atilafassina atilafassina marked this pull request as ready for review November 23, 2025 15:33
Copilot finished reviewing on behalf of atilafassina November 23, 2025 15:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new GitHub Actions workflow to validate that the exported TypeScript types from the monorepo packages are consumable and accurate. The workflow uses @arethetypeswrong/cli to detect common issues with package type definitions that could cause problems for consumers.

Key Changes:

  • Introduces automated type checking for distributed packages using @arethetypeswrong/cli
  • Configured with a matrix strategy to support checking multiple packages (currently just "start")
  • Runs on pull requests and pushes to the main branch

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@atilafassina atilafassina enabled auto-merge (squash) November 23, 2025 17:16
atilafassina and others added 2 commits November 23, 2025 18:18
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@atilafassina atilafassina merged commit e3deaa0 into main Nov 23, 2025
9 of 10 checks passed
@atilafassina atilafassina deleted the ci/attw branch November 23, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants