Skip to content

Conversation

@atilafassina
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 24, 2025

⚠️ No Changeset found

Latest commit: 82b15db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Nov 24, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 82b15db
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6924ce2cff65c100080cd683
😎 Deploy Preview https://deploy-preview-2022--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atilafassina atilafassina enabled auto-merge (squash) November 24, 2025 21:29
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 24, 2025

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2022
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2022

commit: 82b15db

@atilafassina atilafassina merged commit d887855 into main Nov 24, 2025
10 checks passed
@atilafassina atilafassina deleted the fixutres/private branch November 24, 2025 21:46
@huseeiin
Copy link
Contributor

we should also change the tsconfig this way:
change module to "esnext" and moduleResolution to "bundler" (in nitro-3 example) and delete allowSyntheticDefaultImports and esModuleInterop since they are not needed when moduleResolution is set to "bundler"

@huseeiin
Copy link
Contributor

also add "types": ["vite/client"] to tsconfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants