fix: strip baseURL prefix before matching API routes#2117
Open
themavik wants to merge 2 commits intosolidjs:mainfrom
Open
fix: strip baseURL prefix before matching API routes#2117themavik wants to merge 2 commits intosolidjs:mainfrom
themavik wants to merge 2 commits intosolidjs:mainfrom
Conversation
Root cause: matchAPIRoute used the full pathname including the base prefix while routes are registered without it, causing 404 for API routes when server.baseURL is configured. Made-with: Cursor
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2 tasks
|
commit: |
themavik
commented
Mar 19, 2026
Author
themavik
left a comment
themavik
left a comment
There was a problem hiding this comment.
Reviewed the changes — the implementation looks correct and addresses the issue well.
brenelz
approved these changes
Mar 19, 2026
Contributor
|
Could you please add a changeset and if possible add some tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2106.
Root cause:
matchAPIRouteused the full pathname (e.g./admin/api/my-route) while routes are registered without the base prefix (e.g./api/my-route). Whenserver.baseURLis configured, the base prefix was not stripped before lookup, causing all API routes to return 404.Fix: Strip the
baseURLprefix from the pathname before matching API routes.Changes
packages/start/src/server/handler.ts: UpdatedstripBaseUrlto useSERVER_BASE_URL(fromserver.baseURL) when available, with fallback toBASE_URLpackages/start/src/config/index.ts: Addedimport.meta.env.SERVER_BASE_URLto the define block whenserver.baseURLis configuredpackages/start/src/env.d.ts: UncommentedSERVER_BASE_URLtype definitionTesting
Made with Cursor