Open
Conversation
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
In createBaseHandler (packages/start/src/server/handler.js), when USING_SOLID_START_DEV_SERVER is true, the raw Solid stream from renderToStream is returned directly to avoid a
TransformStream cancellation crash. However, createBaseHandler now wraps the handler in an H3 app (new H3() + app.use(handler)). The dev server in dev-server.js calls
serverEntry.default.fetch(webReq) — which is H3.fetch(). h3's response pipeline (toResponse → prepareResponse → prepareResponseBody) doesn't recognize the Solid
stream object (it's not a Response, ReadableStream, string, or any known type), so it falls through to { body: val }. When srvx's sendNodeResponse writes this to the
Node response via nodeRes.write(), the object is coerced to the string "[object Object]", which is all the browser receives.
What is the new behavior?
The dev server path pipes the Solid stream through a TransformStream and wraps the readable side in a standard Response, which h3 handles natively. This matches what
the non-dev code path already does (pipe through TransformStream), with the addition of the Response wrapper so h3 passes it through without transformation.
Other information