Skip to content

untrack JSON.stringify to avoid reactive side-effects on serialization. #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryansolid merged 4 commits into from
Aug 26, 2022
Merged

untrack JSON.stringify to avoid reactive side-effects on serialization. #1177

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
332c55d
untrack JSON.stringify to avoid reactive side-effects on serialization.
LiQuidProQuo Aug 25, 2022
a9658f4
untrack JSON.stringify to avoid reactive side-effects on serialization.
LiQuidProQuo Aug 25, 2022
19d9174
keep immdiately evaluated module code, below its indirect declared le…
LiQuidProQuo Aug 25, 2022
5c2a8f5
Merge branch 'next' into signal-hash-untrack-json-stringify
ryansolid Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 25 additions & 20 deletions packages/solid/src/reactive/signal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ const UNOWNED: Owner = {
owner: null
};
const NO_INIT = {};
const [transPending, setTransPending] = /*@__PURE__*/ createSignal(false);
export var Owner: Owner | null = null;
export let Transition: TransitionState | null = null;
let Scheduler: ((fn: () => void) => any) | null = null;
Expand All @@ -32,6 +31,9 @@ let Effects: Computation<any>[] | null = null;
let ExecCount = 0;
let rootCount = 0;

// keep immdiately evaluated module code, below its indirect declared let dependencies like Listener
const [transPending, setTransPending] = /*@__PURE__*/ createSignal(false);

declare global {
var _$afterUpdate: () => void;
var _$afterCreateRoot: (root: Owner) => void;
Expand Down Expand Up @@ -1048,25 +1050,28 @@ export function hashValue(v: any): string {
typeof v === "string"
? hash(v)
: hash(
JSON.stringify(v, (k, v) => {
if (typeof v === "object" && v != null) {
if (s.has(v)) return;
s.add(v);
const keys = Object.keys(v);
const desc = Object.getOwnPropertyDescriptors(v);
const newDesc = keys.reduce((memo, key) => {
const value = desc[key];
// skip getters
if (!value.get) memo[key] = value;
return memo;
}, {} as any);
v = Object.create({}, newDesc);
}
if (typeof v === "bigint") {
return `${v.toString()}n`;
}
return v;
}) || ""
untrack(
() =>
JSON.stringify(v, (k, v) => {
if (typeof v === "object" && v != null) {
if (s.has(v)) return;
s.add(v);
const keys = Object.keys(v);
const desc = Object.getOwnPropertyDescriptors(v);
const newDesc = keys.reduce((memo, key) => {
const value = desc[key];
// skip getters
if (!value.get) memo[key] = value;
return memo;
}, {} as any);
v = Object.create({}, newDesc);
}
if (typeof v === "bigint") {
return `${v.toString()}n`;
}
return v;
}) || ""
)
)
}`;
}
Expand Down