Skip to content

fix: non-conforming code#1216

Merged
ryansolid merged 1 commit intosolidjs:mainfrom
yzqzy:fix-quotes
Sep 9, 2022
Merged

fix: non-conforming code#1216
ryansolid merged 1 commit intosolidjs:mainfrom
yzqzy:fix-quotes

Conversation

@yzqzy
Copy link
Contributor

@yzqzy yzqzy commented Sep 9, 2022

  1. change single quotes to double quotes.
  2. remove useless commas.
// packages/solid/rollup.config.js

import { fileURLToPath } from "node:url";

image

image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3021257112

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.997%

Totals Coverage Status
Change from base Build 3012441967: 0.0%
Covered Lines: 1261
Relevant Lines: 1346

💛 - Coveralls

@ryansolid ryansolid merged commit 850b117 into solidjs:main Sep 9, 2022
@ryansolid
Copy link
Member

Thanks

@yzqzy yzqzy deleted the fix-quotes branch September 9, 2022 22:40
lilybw pushed a commit to lilybw/solid that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants