import manifest instead of reading it

[huseeiin]

Summary

import manifest instead of reading it

How did you test this change?

ran build and it was inlined

[changeset-bot]

⚠️ No Changeset found

Latest commit: e0d5d95

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[ryansolid]

Is this the approach we should be taking with the Vite Plugin too? I didn't because of TS. But I'm open to discussing that (in that repo).

Also this PR moved a bunch of other stuff around. So distracts from the actual change.

[huseeiin]

Is this the approach we should be taking with the Vite Plugin too? I didn't because of TS. But I'm open to discussing that (in that repo).

Also this PR moved a bunch of other stuff around. So distracts from the actual change.

so long as it will run in the runtime, you should never use node:fs obviously because it won't work in edge

[ryansolid]

Good point.. yeah I had a runtime helper .. Ok I will change the vite plugin.

[huseeiin]

Good point.. yeah I had a runtime helper .. Ok I will change the vite plugin.

yes small disclaimer: by "run in the runtime" i meant END result code that will be deployed (like the one you run with node index.js), so if its build time its completely fine.