Skip to content

fix: resolve solid-element owner marker lookup#2705

Merged
ryansolid merged 1 commit into
mainfrom
fix-element-owner-markers-main
May 18, 2026
Merged

fix: resolve solid-element owner marker lookup#2705
ryansolid merged 1 commit into
mainfrom
fix-element-owner-markers-main

Conversation

@ryansolid
Copy link
Copy Markdown
Member

Summary

  • Fix solid-element owner lookup so ancestor host _$owner markers are returned when found during the parent walk.
  • Add a patch changeset for solid-element.

Fixes #2364

Test plan

  • git diff --check
  • Attempted pnpm --filter solid-element build; blocked in the fresh worktree by existing Solid 1 generated type/self-resolution setup after dependency install and Solid JS build.

Made with Cursor

Ensure nested custom elements inherit context from ancestor owner markers instead of falling back to independent roots.

Co-authored-by: Cursor <cursoragent@cursor.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 18, 2026

🦋 Changeset detected

Latest commit: 0bc9c4d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
solid-element Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryansolid ryansolid merged commit 1282259 into main May 18, 2026
1 check passed
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 26049658695

Coverage increased (+0.1%) to 86.244%

Details

  • Coverage increased (+0.1%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 3 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

3 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
packages/solid/store/src/mutable.ts 2 90.0%
packages/solid/src/reactive/scheduler.ts 1 80.39%

Coverage Stats

Coverage Status
Relevant Lines: 2731
Covered Lines: 2413
Line Coverage: 88.36%
Relevant Branches: 1180
Covered Branches: 960
Branch Coverage: 81.36%
Branches in Coverage %: Yes
Coverage Strength: 500.43 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

context from the parent web-component is not shared to its children | solid-element

2 participants