Fix/improve types for Resource and For/Index/mapArray/indexArray#590
Merged
ryansolid merged 2 commits intosolidjs:mainfrom Aug 3, 2021
Merged
Fix/improve types for Resource and For/Index/mapArray/indexArray#590ryansolid merged 2 commits intosolidjs:mainfrom
Resource and For/Index/mapArray/indexArray#590ryansolid merged 2 commits intosolidjs:mainfrom
Conversation
Pull Request Test Coverage Report for Build 1089867614
💛 - Coveralls |
lilybw
pushed a commit
to lilybw/solid
that referenced
this pull request
Nov 12, 2025
…rray` (solidjs#590) * remove undefined from Resource<T> extends Accessor<T | undefined> * make For and Index also accept falsy values for the each prop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor changes to types.
Resource<T>still extendedAccessor<T | undefined>despite other changes tocreateResource. This PR completes the fix intended in 85fe17b removing theundefined.For,Index,mapArrayandindexArrayso that patterns such as<For each={resource()}>and<For each={store.nullable?.list}>work. I'm not sure iffalseis necessary here, but added it anyway for consistency withShow.