Fix payment bugs - #114
Closed
jordan-brough wants to merge 4 commits into
Closed
Conversation
We were getting incorrect errors after running `reconcile_with_credit_card` because some of the cached payment data on the order was out of date.
When calculating amounts with store credits. Previously an already-auth'd store credit payment was ignored, resulting in incorrect payment amounts. Cherry-picked from https://github.com/bonobos/spree_store_credit_payment_method/commit/9ba4939 and modified for the updated code in solidus.
Use more accurate orders to avoid weird mismatched amounts.
Member
|
馃憤 |
Contributor
Author
|
Merging since bonobos team gave a 馃憤 in the bonbos repo already. |
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Jun 26, 2024
Use Bootstrap cards for admin UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied and updated from https://github.com/bonobos/spree_store_credit_payment_method/pull/68
These were resulting in bogus "Unable to pay for order using store credits" errors which left users stuck in the "payment" state without being able to progress.
Also: Make some specs more reliable.