Fix circular reference in factory#3959
Merged
kennyadsl merged 1 commit intosolidusio:masterfrom Feb 26, 2021
Merged
Conversation
This was causing a double in-memory addition of the same line item to an order. From the repository root: ```bash gem which factory_bot bin/rails console ``` And then, from the console: ```ruby $LOAD_PATH << '/lib/directory/for/factory/bot/from/above/' require_relative '../core/lib/spree/testing_support/factories/order_factory' order = FactoryBot.create(:order_with_totals) order.line_items.count # 1 order.line_items.size # 2, before this commit order.line_items.size # 1, after this commit ```
waiting-for-dev
added a commit
to solidusio/solidus_starter_frontend
that referenced
this pull request
Feb 25, 2021
We were adding another line to match buggy behavior caused by the circular reference fixed in solidusio/solidus#3959. Tests will be green once both changes are integrated.
3 tasks
kennyadsl
added
changelog:solidus_core
jarednorman
approved these changes
Feb 25, 2021
spaghetticode
approved these changes
Feb 26, 2021
Member
spaghetticode
left a comment
spaghetticode
left a comment
There was a problem hiding this comment.
@waiting-for-dev thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing a double in-memory addition of the same line item to an
order.
From the repository root:
And then, from the console:
Description
Checklist:
cc @kennyadsl