v2.10 - Update importing fonts.googleapis.com to use SSL#4218
Merged
waiting-for-dev merged 1 commit intosolidusio:v2.10from Dec 2, 2021
Merged
Conversation
On 23/11/2021, google started to require ssl to access `//fonts.googleapis.com/css`, causing the import in the solidus frontend stylesheet to fail in CI. This breaks solidus and tests that run against the solidus_frontend. We can resolve this by explicitly using the https protocol. Error example: app.circleci.com/pipelines/github/solidusio/solidus/2791/workflows/e62ff646-9ae6-4e65-b20f-e1f7a109d3a1/jobs/26572 Blocking of this URL in testing_support was updated to bring it inline with how url's are blacklisted in future solidus versions. Even though solidus 2.10 is at end of life, some solidus extensions still test and maintain support against this version of solidus, such as SuperGoodSoft/solidus_taxjar. Co-authored-by: Ryan Woods <contact@ryanofwoods.com>
Noah-Silvera
changed the title
Noah-Silvera
changed the title
jarednorman
approved these changes
Dec 1, 2021
waiting-for-dev
approved these changes
Dec 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 23/11/2021, google started to require ssl to access
//fonts.googleapis.com/css, causing the import in the solidus frontend stylesheet to fail in CI. This breaks solidus and tests that run against the solidus_frontend. We can resolve this by explicitly using the https protocol.Error example:
https://app.circleci.com/pipelines/github/solidusio/solidus/2791/workflows/e62ff646-9ae6-4e65-b20f-e1f7a109d3a1/jobs/26572
Blocking of this URL in testing_support was updated to bring it inline
with how url's are blacklisted in future solidus versions.
Even though solidus 2.10 is at end of life, some solidus extensions still test and maintain support against this version of solidus, such as SuperGoodSoft/solidus_taxjar, so it's important to continue to enable that testing.
This PR was based off the three PRs that cover actively maintained solidus versions created by @RyanofWoods
Checklist: