Add more payment information in the shipments API response#442
Merged
jordan-brough merged 2 commits intoOct 15, 2015
Conversation
Adds some information about the payment’s source in the shipments API response. This allows us to display more details to the customer about the payments associated with the shipment’s order.
Contributor
|
nice 👍 |
Member
There was a problem hiding this comment.
What about switching this to:
if s.respond_to?(:cc_type)
That will allow other objects which implement cc_type to use this. Probably not super helpful with this attribute, but it's a good pattern to follow.
Contributor
Author
There was a problem hiding this comment.
@gmacdougall Sounds good, added another commit to address this and hopefully make adding more attributes in the future a little easier.
Member
|
👍 |
Contributor
Author
|
@jordan-brough good to merge? |
Contributor
|
👍 |
jordan-brough
added a commit
that referenced
this pull request
Oct 15, 2015
Add more payment information in the shipments API response
forkata
pushed a commit
to SuperGoodSoft/solidus
that referenced
this pull request
May 21, 2026
Improve CI reliability and get builds passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some information about the payment’s source in the shipments API response.
This allows us to display more details to the customer about the payments associated with the shipment’s order.