Merged
Conversation
github-actions
bot
added
the
changelog:repository
kennyadsl
force-pushed
the
kennyadsl/sandbox-with-js
branch
from
82f3b53 to
4ee1aa0
Compare
elia
approved these changes
Feb 8, 2023
Member
elia
left a comment
elia
left a comment
There was a problem hiding this comment.
The CI failure I think is tied to the merged autocomplete feature, I've seen it also on solidus_stripe.
waiting-for-dev
approved these changes
Feb 8, 2023
Member
Author
|
@elia the point of this PR is to fix that failure so I think I need to take a closer look 😄 |
New Rails versions do not come with webpacker anymore. We can safely generate sandboxes with Javascript now. This is also needed because now the Starter Frontend has some Stimulus/Turbo code that relies on the Rails JS stack to work. This change needs to bump the CircleCI cache for the installer test, because the Rails application needs to be re-installed without the --skip-javascript option.
kennyadsl
force-pushed
the
kennyadsl/sandbox-with-js
branch
from
4ee1aa0 to
e097e9b
Compare
github-actions
bot
added
the
changelog:solidus_core
kennyadsl
changed the title
kennyadsl
changed the title
kennyadsl
force-pushed
the
kennyadsl/sandbox-with-js
branch
2 times, most recently
from
561485d to
954b8ff
Compare
Member
Author
|
I moved the cache issue to #4927. We can merge the first commit indipendently. |
kennyadsl
force-pushed
the
kennyadsl/sandbox-with-js
branch
from
954b8ff to
033bad1
Compare
github-actions
bot
removed
the
changelog:solidus_core
waiting-for-dev
approved these changes
Feb 9, 2023
kennyadsl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New Rails versions do not come with Webpacker anymore. We can safely generate sandboxes with Javascript now.
This is also needed because the Starter Frontend has some Stimulus/Turbo code that relies on the Rails JS stack.
Fixes CI failures, like https://app.circleci.com/pipelines/github/solidusio/solidus/4021/workflows/0a92bb5c-2fd6-460c-8cc7-7ff1a69b968e/jobs/38086
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: