Fix: {LineItem;Shipment}#total_before_tax: Ignore stale adjustments - #6521
Open
mamhoff wants to merge 1 commit into
Open
Fix: {LineItem;Shipment}#total_before_tax: Ignore stale adjustments#6521mamhoff wants to merge 1 commit into
mamhoff wants to merge 1 commit into
Conversation
SolidusPromotions will mark adjustments for destruction if they no longer apply (especially if there are two adjustments from promotions from the same lane). With unpersisted orders, this can lead to `#total_before_tax` on line items and shipments to count those stale adjustments. The fix is to always exclude adjustments that are marked for destruction.
github-actions
Bot
added
the
changelog:solidus_core
mamhoff
added
backport-v4.7
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6521 +/- ##
=======================================
Coverage 91.51% 91.51%
=======================================
Files 839 839
Lines 18057 18057
=======================================
Hits 16525 16525
Misses 1532 1532 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Test failures in solidus admin are unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SolidusPromotions will mark adjustments for destruction if they no longer apply (especially if there are two adjustments from promotions from the same lane). With unpersisted orders, this can lead to
#total_before_taxon line items and shipments to count those stale adjustments.The fix is to always exclude adjustments that are marked for destruction.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: