Fix docker dev setup - #6533
Open
jarednorman wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
the
changelog:repository
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6533 +/- ##
=======================================
Coverage 92.14% 92.14%
=======================================
Files 1035 1035
Lines 21151 21151
=======================================
Hits 19490 19490
Misses 1661 1661 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tvdeyen
approved these changes
Aug 11, 2026
tvdeyen
left a comment
tvdeyen
left a comment
Member
There was a problem hiding this comment.
Nice. I have one non-blocking question
| services: | ||
| mysql: | ||
| image: mysql:8.0 | ||
| image: docker.io/mysql:8.0 |
Member
There was a problem hiding this comment.
Why is this necessary? can we explain in the commit message?
tvdeyen
reviewed
Aug 11, 2026
| @@ -1,16 +1,16 @@ | |||
| version: "3.7" | |||
Member
There was a problem hiding this comment.
WARN[0000] /Users/tvd/code/solidus/docker-compose.yml: the attribute
versionis obsolete, it will be ignored, please remove it to avoid potential confusion
Can we remove this line while we are here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #6510 and #6511, superseding #6513. I took the parts I wanted from #6513 and fixed the remaining issue that broke
docker compose upfor everyone, not just podman users.Closes #6510.
Checklist