Fix docker run instructions and hardcode internal port - #6567
Merged
tvdeyen merged 1 commit intoSep 2, 2026
Merged
Conversation
Noah-Silvera
changed the title
There's no real reason to make the internal rails port used in a docker container configurable. All that matters is the host port. The docker compose instructions also gave the wrong command for starting the app. Starting the rails server directly caused a tailwindcss error on the frontend AND admin - we need to call bin/dev within Docker to start the tailwind watch process Co-authored-by: Sofia Besenki <sofia@super.gd>
Noah-Silvera
force-pushed
the
noahsilvera/update-docker-instructions
branch
from
September 1, 2026 18:57
e2d2ca4 to
1242a81
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6567 +/- ##
=======================================
Coverage 92.26% 92.26%
=======================================
Files 1037 1037
Lines 21211 21211
=======================================
Hits 19570 19570
Misses 1641 1641 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jarednorman
approved these changes
Sep 1, 2026
Noah-Silvera
marked this pull request as ready for review
September 1, 2026 21:01
adammathys
approved these changes
Sep 2, 2026
tvdeyen
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There's no real reason to make the internal rails port used in a docker container configurable. All that matters is the host port.
The docker compose instructions also gave the wrong command for starting the app. Starting the rails server directly caused a tailwindcss error
on the frontend AND admin - we need to call bin/dev within Docker to start the tailwind watch process
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: