Skip to content

Release SOP fixes#155

Closed
elia wants to merge 2 commits intomasterfrom
elia/release-sop-fixes
Closed

Release SOP fixes#155
elia wants to merge 2 commits intomasterfrom
elia/release-sop-fixes

Conversation

@elia
Copy link
Copy Markdown
Member

@elia elia commented Oct 20, 2020

Summary

  • we had problems when the homepage was including #readme in the URI
  • we were tagging the wrong commit (the one without the changelog) when releasing

Checklist

  • I have structured the commits for clarity and conciseness.
  • I have added relevant automated tests for this change.

elia added 2 commits October 20, 2020 11:50
@elia
Take the source URI from metadata and just use the path
e22f617 
Before this it was trying to use the homepage including the `#readme`
anchor as the project name.
@elia
Keep the tag on the amended commit when releasing
952a161 
Also reduces requests for interactive input to a minimum.
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Oct 20, 2020

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

@mergify mergify Bot added the needs changelog label Needs a label to determine the type of change. label Oct 20, 2020
@elia elia added bug Describes or fixes a bug. documentation Improves the documentation. and removed needs changelog label Needs a label to determine the type of change. labels Oct 20, 2020
@elia elia changed the title Elia/release sop fixes Release SOP fixes Oct 20, 2020
@elia
Copy link
Copy Markdown
Member Author

elia commented Nov 13, 2020

The release instructions have been moved to a wiki under solidus and the issue with the url has been fixed.

@elia elia closed this Nov 13, 2020
jarednorman pushed a commit to SuperGoodSoft/solidus_dev_support that referenced this pull request Feb 4, 2026
@aldesantis
Merge pull request solidusio#155 from solidusio-contrib/aldesantis/re…
3bbdfc3 
…factor-dispatchers

Improve dispatchers API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Describes or fixes a bug. documentation Improves the documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@elia