Skip to content

Release SOP fixes #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elia wants to merge 2 commits into from
Closed

Release SOP fixes #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e22f617
Take the source URI from metadata and just use the path
elia Oct 20, 2020
952a161
Keep the tag on the amended commit when releasing
elia Oct 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/solidus_dev_support/rake_tasks.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,11 @@ def install_rspec_task
def install_changelog_task
require 'github_changelog_generator/task'

user, project = gemspec.homepage.split("/")[3..5]
source_code_uri = URI.parse(gemspec.metadata['source_code_uri'] || gemspec.homepage)
user, project = source_code_uri.path.split("/", 3)[1..2]

GitHubChangelogGenerator::RakeTask.new(:changelog) do |config|
config.user = user || 'solidus-contrib'
config.user = user || 'solidusio-contrib'
config.project = project || gemspec.name
config.future_release = "v#{gemspec.version}"
end
Expand Down
6 changes: 4 additions & 2 deletions lib/solidus_dev_support/templates/extension/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,10 @@ Your new extension version can be released using `gem-release` like this:
```shell
bundle exec gem bump -v 1.6.0
bin/rake changelog
git commit -a --amend
git push
git add CHANGELOG.md
git commit --amend --no-edit
gem tag
git push --tags
bundle exec gem release
```

Expand Down
2 changes: 1 addition & 1 deletion lib/solidus_dev_support/templates/extension/gem_release.yml.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ bump:
recurse: false
file: 'lib/<%=file_name%>/version.rb'
message: Bump <%=class_name%> to %{version}
tag: true
tag: false