Move factories to their new location when updating extensions#173
Move factories to their new location when updating extensions#173
Conversation
mergify
Bot
added
the
needs changelog label
|
It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
Additionally, the maintainer may also want to add one of the following:
Once the correct labels have been set, simply remove the |
| sh('solidus extension .') | ||
|
|
||
| expect(lib.join("testing_support/factories.rb")).to exist | ||
| expect(lib.join("testing_support/factories")).to exist |
There was a problem hiding this comment.
@elia this expectation is failing, I'm not sure how to debug this properly. When you have some time, can you please help me?
kennyadsl
added
enhancement
kennyadsl
force-pushed
the
kennyadsl/move-factories-when-updating
branch
from
03b4fe8 to
3e0e246
Compare
kennyadsl
changed the title
kennyadsl
force-pushed
the
kennyadsl/move-factories-when-updating
branch
from
3e0e246 to
7e294c7
Compare
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
…subscribable-variants-bug Fix legacy unsubscribable subscriptions not being processed
make gem work with solidus_support >0.5
1 participant
Summary
Factories should be placed into a specific folder to be correctly loaded by the
SolidusDevSupport::TestingSupport::Factories.load_for()method. Although it works even with the legacy path (emitting a deprecation warning), this automated step could help us migrating extensions with time.This PR is a draft because there are some issues testing the code, I will revisit this later, hopefully with someone that has more experience with these specs.
Checklist