Skip to content

Update sandbox.tt Solidus install generator usage#193

Closed
RyanofWoods wants to merge 1 commit intosolidusio:masterfrom
RyanofWoods:ryanofwoods/update-sandbox-solidus-generator-usage
Closed

Update sandbox.tt Solidus install generator usage#193
RyanofWoods wants to merge 1 commit intosolidusio:masterfrom
RyanofWoods:ryanofwoods/update-sandbox-solidus-generator-usage

Conversation

@RyanofWoods
Copy link
Copy Markdown

Summary

The --with-authentication flag is deprecated in favour for the --authentication flag that supports the following options: devise, existing, custom, none.

Checklist

  • I have structured the commits for clarity and conciseness.
  • I have added relevant automated tests for this change.

@RyanofWoods RyanofWoods force-pushed the ryanofwoods/update-sandbox-solidus-generator-usage branch from 1bd89e8 to c7585ef Compare November 9, 2022 10:20
@mergify mergify Bot added the needs changelog label Needs a label to determine the type of change. label Nov 9, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Nov 9, 2022

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

The `--with-authentication` flag is deprecated in favour for the
`--authentication` flag that supports the following options:
`devise, existing, custom, none`.
@RyanofWoods RyanofWoods force-pushed the ryanofwoods/update-sandbox-solidus-generator-usage branch from c7585ef to dc88024 Compare November 10, 2022 08:30
@elia elia added enhancement Improves an existing feature. and removed needs changelog label Needs a label to determine the type of change. labels Dec 14, 2022
Copy link
Copy Markdown
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit conflicted about this, as the new option is only available on solidus master, and the old one is deprecated but still available, was it only a matter of solving the deprecation or bumped into some other issue?

@RyanofWoods
Copy link
Copy Markdown
Author

I understand @elia, is it because we want to have old Solidus version support?

It was just to get rid of the deprecation.

@elia
Copy link
Copy Markdown
Member

elia commented Dec 15, 2022

I understand @elia, is it because we want to have old Solidus version support?

Yes, so far solidus_dev_support was designed to help in making extensions compatible with all currently supported versions of Solidus (i.e. not EOL). So you could export SOLIDUS_BRANCH=v3.0 and bin/setup and then recreate the sandbox using that version to try the extension on a real app with the version of solidus you want.

Hope this makes sense.

forkata pushed a commit to SuperGoodSoft/solidus_dev_support that referenced this pull request Mar 12, 2026
Update German Refund and Returns translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improves an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants