Add option_type field within OptionValue type#184
Merged
Conversation
kennyadsl
approved these changes
Sep 10, 2021
Member
|
@waiting-for-dev do you get why codeclimate is complaining? |
This allows to retrieve option value values along their option type
name, description, etc. E.g.:
```graphql
query getProduct {
productBySlug(slug: "solidus-t-shirt") {
name
description
variants {
nodes {
id
sku
position
prices {
nodes {
amount
currency {
htmlEntity
}
}
}
optionValues {
nodes {
id
name
presentation
optionType {
name
position
presentation
}
}
}
}
}
}
}
```
Fixes #171
7d68a5a to
38df4ba
Compare
Contributor
Author
As part of the code to be pushed is auto-generated, it helped decrease the ratio of tested/non-tested code on my push. I added a test to be compliant. I don't think they're super-useful, but it's consistent with the approach taken in the extension, so it's fine by now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to retrieve option value values along their option type
name, description, etc. E.g.:
Fixes #171