Skip to content

Add CSS and Tabbed Layout to Panel#2

Merged
localjo merged 19 commits intomasterfrom
nice-ui
Jul 11, 2014
Merged

Add CSS and Tabbed Layout to Panel#2
localjo merged 19 commits intomasterfrom
nice-ui

Conversation

@localjo
Copy link
Copy Markdown
Member

@localjo localjo commented Jul 7, 2014

Since there are two different things being displayed by the devtools, it would make sense to have a tabbed layout in the panel to switch between the Page Context JSON and the Server Error Logs. Having a tabbed layout would be good for future additions to the devtools.

(Another possibility would be to surface the error logs into the console or panel sidebar. But that depends partially on the outcome of #1 and what format the error logs are surfaced in.)

Along with this issue, some CSS and UI icons should be added. I'm thinking of including the Blink source for this, to match the native look of the rest of the Chrome DevTools. The Facebook React DevTools do this, and Paul Irish recommends it, but there isn't much documentation about it.

@localjo localjo added this to the v1.0.0 milestone Jun 23, 2014
@localjo localjo self-assigned this Jun 23, 2014
@localjo localjo mentioned this pull request Jun 24, 2014
@pushred
Copy link
Copy Markdown
Member

pushred commented Jun 25, 2014

The native styles have been getting awfully erratic! I think this version would probably feel the most at-home:

screen shot 2014-06-25 at 4 53 46 pm

For the error logs there could be an interesting dynamic in providing a different log level in the main pane that summarizes everything and uses the sidebar panel for display debug level details. That'd match DOM and network request inspection behavior.

@pushred
Copy link
Copy Markdown
Member

pushred commented Jun 25, 2014

My first inclination was sidebar tabs actually, similar to the Timeline/Profiles tabs. They appear like WebKit holdovers but just noticed that this is how Ember handles tabs as well, with a much friendlier feel overall.

ember-sidebar

There's been a bit of protest over the removal of the tab bar icons, but with vertical constraints being a factor in so many laptops, etc. I can easily see why they did that. Sidebar tabs (OS X Finder offers more precedent) are really the compromise.

@localjo
Copy link
Copy Markdown
Member Author

localjo commented Jun 26, 2014

I was thinking sidebar tabs too. I think a layout similar to the Ember devtools would work well for the Solidus tools.

@localjo localjo mentioned this pull request Jul 1, 2014
@localjo
Copy link
Copy Markdown
Member Author

localjo commented Jul 10, 2014

Updated to-do:

  • match devtools style
  • add tab icons
  • add clear log button
  • improve info/messages tab
  • automatically switch to info tab on non-solidus pages

@pushred
Copy link
Copy Markdown
Member

pushred commented Jul 11, 2014

Some comments:

  • Can't scroll in the inspector pane
  • Resizing between the panes would be nice to have. Low priority, this is an irrational OCD impulse to control that width 😬

Going to open an issue or two for some other things I'm seeing.

@pushred
Copy link
Copy Markdown
Member

pushred commented Jul 11, 2014

Couple more:

  • If the current site isn't a Solidus site, you should disable the Context/Logs tabs.
  • Navigating away to a non-Solidus site isn't changing the Info tab, etc. Navigating to a Solidus site works as expected though. An undock + redock also does the trick.

@localjo
Copy link
Copy Markdown
Member Author

localjo commented Jul 11, 2014

  • Disable Context/Logs Tabs on non-solidus pages.
  • Add resizing to tabs/panels

@pushred
Copy link
Copy Markdown
Member

pushred commented Jul 11, 2014

How about choosing a font & color scheme consistent with the output of objects in the console?

@localjo
Copy link
Copy Markdown
Member Author

localjo commented Jul 11, 2014

@pushred Do you mean the font & color scheme for Inspector-JSON or for the server logs?

@pushred
Copy link
Copy Markdown
Member

pushred commented Jul 11, 2014

The inspector, haven't checked out the logs yet gotta get that Solidus branch going again with the site I'm working on. The font we specify for Inspector JSON (which was ripped out of the Storyteller editor) is just feeling really blurry in contrast to whatever Chrome is using when I'm switching between tabs.

screen shot 2014-07-11 at 4 39 35 pm

screen shot 2014-07-11 at 4 39 45 pm

@localjo
Copy link
Copy Markdown
Member Author

localjo commented Jul 11, 2014

@pushred I matched the Inspector-JSON styles to Chrome's default. I'm ready to merge this pull request if you agree.

@pushred
Copy link
Copy Markdown
Member

pushred commented Jul 11, 2014

All set! 👍

localjo added a commit that referenced this pull request Jul 11, 2014
Add CSS and Tabbed Layout to Panel
@localjo localjo merged commit c360d6d into master Jul 11, 2014
@localjo localjo deleted the nice-ui branch July 17, 2014 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants