Changes #1
Closed
Changes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…laration in user code.
…hout tricking with enums.
This is because QCad file don't display any dimensions with it.
Contributor
Author
|
This is an issue, needed to be tested. By some reason, autocad don't read some files with some line weights. Because of enum-lWeight we have to introduce lRawWeight. if we want to avoid it, we should create mm-to-enum, enum-to-mm functions. |
Contributor
|
Yes, please replace lWeight with lRawWeight entirely (rename it to break any code that relies on the semantics of lWeight rather than make it do the wrong thing because of an implicit conversion) and add the conversion functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.