Adding config option to immediately edit dimensions#514
Adding config option to immediately edit dimensions#514whitequark merged 2 commits intosolvespace:masterfrom
Conversation
whitequark
left a comment
There was a problem hiding this comment.
Looks OK other than the comment.
src/confscreen.cpp
Outdated
| SS.automaticLineConstraints ? CHECK_TRUE : CHECK_FALSE); | ||
| Printf(false, " %Fd%f%Ll%s use turntable mouse navigation%E", &ScreenChangeTurntableNav, | ||
| SS.turntableNav ? CHECK_TRUE : CHECK_FALSE); | ||
| Printf(false, " %Fd%f%Ll%s immediately edit dimensions%E", |
There was a problem hiding this comment.
What about edit newly added dimensions? The variable naming is fine, but the preference is a bit confusing.
The existing behavior should not change for people who are already using SolveSpace. |
|
Changed the default to false and used your suggested label. Will take a bit... |
|
I can just squash while merging in a simple case like this, GitHub has a button for it. |
|
Cool! then I leave it =) Which seemed to work allright =) |
|
Usually people use |
|
Indeed, I am not very familiar with git I notices since I mostly only commit and push things with it, should read the manual again... |
976239c to
3728ee9
Compare
|
Force pushed it anyway ;) |
|
This needs a changelog addition as well. |
Here it is again, this time with config option.
Let me know if the default should be on or off, and if the variables / place in the preferences pane are fine with you.
The option does now also work on the angle constraint.