Skip to content

Adding config option to immediately edit dimensions#514

Merged
whitequark merged 2 commits intosolvespace:masterfrom
vespakoen:immediate-dimension-mode
Nov 26, 2019
Merged

Adding config option to immediately edit dimensions#514
whitequark merged 2 commits intosolvespace:masterfrom
vespakoen:immediate-dimension-mode

Conversation

@vespakoen
Copy link
Copy Markdown
Contributor

Here it is again, this time with config option.

Let me know if the default should be on or off, and if the variables / place in the preferences pane are fine with you.

The option does now also work on the angle constraint.

Copy link
Copy Markdown
Contributor

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK other than the comment.

SS.automaticLineConstraints ? CHECK_TRUE : CHECK_FALSE);
Printf(false, " %Fd%f%Ll%s use turntable mouse navigation%E", &ScreenChangeTurntableNav,
SS.turntableNav ? CHECK_TRUE : CHECK_FALSE);
Printf(false, " %Fd%f%Ll%s immediately edit dimensions%E",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about edit newly added dimensions? The variable naming is fine, but the preference is a bit confusing.

@whitequark
Copy link
Copy Markdown
Contributor

Let me know if the default should be on or off

The existing behavior should not change for people who are already using SolveSpace.

@vespakoen
Copy link
Copy Markdown
Contributor Author

Changed the default to false and used your suggested label.
Just have to figure out how to squash these commits together now =)

Will take a bit...

@whitequark
Copy link
Copy Markdown
Contributor

whitequark commented Nov 26, 2019

I can just squash while merging in a simple case like this, GitHub has a button for it.

@vespakoen
Copy link
Copy Markdown
Contributor Author

Cool! then I leave it =)
Was just running

git reset --soft HEAD~2

Which seemed to work allright =)

@whitequark
Copy link
Copy Markdown
Contributor

Usually people use git rebase -i which is a bit more flexible, but that works too.

@vespakoen
Copy link
Copy Markdown
Contributor Author

Indeed, I am not very familiar with git I notices since I mostly only commit and push things with it, should read the manual again...

@vespakoen vespakoen force-pushed the immediate-dimension-mode branch from 976239c to 3728ee9 Compare November 26, 2019 21:16
@vespakoen
Copy link
Copy Markdown
Contributor Author

Force pushed it anyway ;)

@whitequark
Copy link
Copy Markdown
Contributor

This needs a changelog addition as well.

@whitequark whitequark merged commit dcdfdec into solvespace:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants