Adding support for metering

[vijasrin]

• Outbound metering P4 model changes in BMV2
• Changes to support the SAI api generation for metering tables
• Skipping failing SAIC tests till the metadata has been updated

[chrispsommers]

Some meeting comments:

• explore indirect counters (Andy)
• optional attributes shouldn't have to be provided in test-cases; code-generator is asserting on number of attributes; needs fix? libsai bmv2 not respecting optional nature of attributes #370

[vijasrin]

SAI API for ref: https://github.com/opencomputeproject/SAI/compare/master...vijasrin:SAI:meter_sai?diff=unified

[vijasrin]

Adding skip for the SAIC tests till the metadata is updated

[taras-keryk-plv]

CI fails for two reasons:

1. metadata is missing in SAI-C because the headers are generated automatically.
   Here is visible what information is missing: https://github.com/taras-keryk-plv/SAI-Challenger/pull/81/files

2. dpugen does not generate config for these new attributes. Therefore, the tests will fail even if # 1 is fixed.
   So we have the next errors:

saiserver: saidasheni.cpp:376: sai_status_t sai_create_eni(sai_object_id_t*, sai_object_id_t, uint32_t, const sai_attribute_t*): Assertion `(matchedParams == expectedParams)' failed.

[413296.894310] traps: saiserver[643376] general protection fault ip:7f5b56bdd941 sp:7f5b4f7fd420 error:0 in libc-2.31.so[7f5b56bdd000+178000]

[chrispsommers]

Hi @taras-keryk-plv could you be more specific which test is failing where dpugen is involved? We can explore updating it. Thank you!- @mgheorghe please take note

[taras-keryk-plv]

Hi @chrispsommers, @mgheorghe
yes, i tried:

make run-saichallenger-client-bash
cd functional
./run-tests.sh --setup=sai_dpu_client_server_snappi.json tutorial/test_sai_vnet_outbound_small_scale_config_via_dpugen.py::TestSaiVnetOutbound

Thank you!

[chrispsommers]

Hi @vijasrin PR #378 was merged, it should address item #1 in #365 (comment). Assuming this is true can you merge from main, re-enable the tests you'd skipped (except for any still depending upon dpugen enhancements)? Thanks.

[chrispsommers]

@vijasrin Do you intend to add any new functional tests to verify the new features?

[chrispsommers]

@reshmaintel mentioned there are PTF test cases against outbound metering, written assuming this PR will get merged. Once it is merged those tests can be upstreamed.