Updated SAI-Challenger to latest main as of May 30#378
Merged
chrispsommers merged 2 commits intosonic-net:mainfrom May 31, 2023
Merged
Updated SAI-Challenger to latest main as of May 30#378chrispsommers merged 2 commits intosonic-net:mainfrom
chrispsommers merged 2 commits intosonic-net:mainfrom
Conversation
Signed-off-by: Andriy Kokhan <andriy.kokhan@gmail.com>
Signed-off-by: Andriy Kokhan <andriy.kokhan@gmail.com>
Collaborator
|
Hi @andriy-kokhan thanks for this. If this gets merged, would this allow @vijasrin to re-enable some of the tests which are skipped in PR #365 (except ones requiring changes to dpugen)? |
Collaborator
Author
This PR enables metadata autogen. But one more improvement is needed - SaiObjType autogen which is addressed in #381. With these two, some of the tests can be re-enabled. To do that, we will probably make another PR into #365. |
Collaborator
|
Thanks for the clarification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new version of SAI-Challenger auto-generates
sai_thrift_metadata.pyin run-time.Fixes Issue #374