Skip to content

Conversation

@ccroy-arista
Copy link
Contributor

@ccroy-arista ccroy-arista commented Sep 5, 2025

Why I did it

To enable the SmartSAF feature on the targer platforms.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Added SmartSAF settings to the Broadcom config/SAI profile files.

How to verify it

From the DUT's CLI, enter the Broadcom shell: bcmsh
Run ps and confirm that the cut thru mode for the desired interfaces is Smart.
Can also confirm SMART_STORE_AND_FORWARD=1 by running: bsh -c "lt traverse -l TM_SMART_STORE_AND_FORWARD_CONFIG"

Which release branch to backport (provide reason below if selected)

  • 202205
  • 202211
  • 202305
  • 202311
  • 202405
  • 202412
  • 202505

Tested branch (Please provide the tested image version)

202412, 202505

Description for the changelog

Update the BCM config files for Arista-7060X6-64PE-B, Arista-7060X6-16PE-384C-B to initialize SmartSAF functionality.

Update the BCM config files for Arista-7060X6-64PE-B,
Arista-7060X6-16PE-384C-B  to initialize SmartSAF functionality.
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zhangyanzhao
Copy link

@lguohan @r12f can you please help to review this PR? Thanks.

@ccroy-arista ccroy-arista marked this pull request as ready for review September 5, 2025 22:59
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Don't initialize SmartSAF functionality for the
Arista-7060X6-64PE-B-C448O16 and Arista-7060X6-64PE-B-C512S2
HWSKUs at this time.
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms
Copy link
Contributor

Hi @ccroy-arista, can you share a csp for me to pick up some context? Thanks

SAI_INIT_CONFIG_FILE=/usr/share/sonic/hwsku/th5-a7060x6-16pe-384c.config.bcm
SAI_NUM_ECMP_MEMBERS=128
SAI_NHG_HIERARCHICAL_NEXTHOP=false
SAI_SWITCH_SWITCHING_MODE_CUT_THROUGH=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why CUT_THROUGH is enabled? Is that expected?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this cause packet with CRC being propagated to neigh devices?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why CUT_THROUGH is enabled? Is that expected?

I've raised this question with Broadcom, waiting on their response.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A follow up question, do we have test to ensure CRC error is not propagated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Response received from Broadcom; sai.profile changes removed.

Initialize SmartSAF functionality for the
Arista-7060X6-64PE-B-C448O16 and Arista-7060X6-64PE-B-C512S2
HWSKUs.
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Remove SAI_SWITCH_SWITCHING_MODE_CUT_THROUGH=true
in the sai.profile files for Arista-7060X6-64PE-B,
Arista-7060X6-16PE-384C-B, as this setting is not
used for smartSAF.
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kperumalbfn kperumalbfn merged commit adac233 into sonic-net:master Sep 18, 2025
20 checks passed
@ccroy-arista ccroy-arista deleted the enable-smartsaf branch September 18, 2025 06:05
@ccroy-arista
Copy link
Contributor Author

Cherry-pick to 202505: #24039

@ccroy-arista
Copy link
Contributor Author

Cherry-pick to 202412: Azure/sonic-buildimage-msft#1637

dakotac-arista added a commit to dakotac-arista/sonic-buildimage that referenced this pull request Sep 18, 2025
mssonicbld added a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 18, 2025
Note: this is a manual backport to 202505 for sonic-net#23908

#### Why I did it
To enable the SmartSAF feature on the targer platforms.

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it
Added SmartSAF settings to the Broadcom config/SAI profile files.

#### How to verify it
From the DUT's CLI, enter the Broadcom shell: `bcmsh`
Run `ps` and confirm that the cut thru mode for the desired interfaces is `Smart`.
Can also confirm `SMART_STORE_AND_FORWARD=1` by running: `bsh -c "lt traverse -l TM_SMART_STORE_AND_FORWARD_CONFIG"`

#### Which release branch to backport (provide reason below if selected)
- [ ] 202205
- [ ] 202211
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [x] 202505

#### Tested branch (Please provide the tested image version)
202412, 202505

#### Description for the changelog
Update the BCM config files for Arista-7060X6-64PE-B, Arista-7060X6-16PE-384C-B  to initialize SmartSAF functionality.
mssonicbld added a commit that referenced this pull request Sep 19, 2025
#24044)

Note: this is a manual backport to 202505 for #23908

#### Why I did it
To enable the SmartSAF feature on the targer platforms.

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it
Added SmartSAF settings to the Broadcom config/SAI profile files.

#### How to verify it
From the DUT's CLI, enter the Broadcom shell: `bcmsh`
Run `ps` and confirm that the cut thru mode for the desired interfaces is `Smart`.
Can also confirm `SMART_STORE_AND_FORWARD=1` by running: `bsh -c "lt traverse -l TM_SMART_STORE_AND_FORWARD_CONFIG"`

#### Which release branch to backport (provide reason below if selected)
- [ ] 202205
- [ ] 202211
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [x] 202505

#### Tested branch (Please provide the tested image version)
202412, 202505

#### Description for the changelog
Update the BCM config files for Arista-7060X6-64PE-B, Arista-7060X6-16PE-384C-B to initialize SmartSAF functionality.
Pterosaur pushed a commit to Azure/sonic-buildimage-msft that referenced this pull request Sep 21, 2025
#1637)

Note: this is a manual backport to msft-202412 for
sonic-net/sonic-buildimage#23908

#### Why I did it
To enable the SmartSAF feature on the targer platforms.

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it
Added SmartSAF settings to the Broadcom config/SAI profile files.

#### How to verify it
From the DUT's CLI, enter the Broadcom shell: `bcmsh`
Run `ps` and confirm that the cut thru mode for the desired interfaces
is `Smart`.
Can also confirm `SMART_STORE_AND_FORWARD=1` by running: `bsh -c "lt
traverse -l TM_SMART_STORE_AND_FORWARD_CONFIG"`

#### Which release branch to backport (provide reason below if selected)
- [ ] 202205
- [ ] 202211
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [x] 202412

#### Tested branch (Please provide the tested image version)
202412, 202505

#### Description for the changelog
Update the BCM config files for Arista-7060X6-64PE-B,
Arista-7060X6-16PE-384C-B to initialize SmartSAF functionality.
r12f pushed a commit to Azure/sonic-buildimage-msft that referenced this pull request Oct 26, 2025
#1637)

Note: this is a manual backport to msft-202412 for
sonic-net/sonic-buildimage#23908

#### Why I did it
To enable the SmartSAF feature on the targer platforms.

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it
Added SmartSAF settings to the Broadcom config/SAI profile files.

#### How to verify it
From the DUT's CLI, enter the Broadcom shell: `bcmsh`
Run `ps` and confirm that the cut thru mode for the desired interfaces
is `Smart`.
Can also confirm `SMART_STORE_AND_FORWARD=1` by running: `bsh -c "lt
traverse -l TM_SMART_STORE_AND_FORWARD_CONFIG"`

#### Which release branch to backport (provide reason below if selected)
- [ ] 202205
- [ ] 202211
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [x] 202412

#### Tested branch (Please provide the tested image version)
202412, 202505

#### Description for the changelog
Update the BCM config files for Arista-7060X6-64PE-B,
Arista-7060X6-16PE-384C-B to initialize SmartSAF functionality.
dakotac-arista added a commit to dakotac-arista/sonic-buildimage-msft that referenced this pull request Oct 30, 2025
bingwang-ms added a commit to Azure/sonic-buildimage-msft that referenced this pull request Oct 31, 2025
Changes missing from msft_202503:
sonic-net/sonic-buildimage#23908
sonic-net/sonic-buildimage#23722

Was already added for Arista-7060X6-64PE-B-O128 in
#1674

<!--
Please make sure you've read and understood our contributing guidelines:
     https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

** Make sure all your commits include a signature generated with `git
commit -s` **

If this is a bug fix, make sure your description includes "fixes #xxxx",
or
     "closes #xxxx" or "resolves #xxxx"

     Please provide the following information:
-->

#### Why I did it

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it

#### How to verify it

<!--
If PR needs to be backported, then the PR must be tested against the
base branch and the earliest backport release branch and provide tested
image version on these two branches. For example, if the PR is requested
for master, 202211 and 202012, then the requester needs to provide test
results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
Ensure to add label/tag for the feature raised. example - PR#2174 under
sonic-utilities repo. where, Generic Config and Update feature has been
labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Dec 4, 2025
sonic-net#23908)

[Arista-7060X6-64PE-B, Arista-7060X6-16PE-384C-B]: Initialize SmartSAF

Signed-off-by: Feng Pan <fenpan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants