-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[Arista-7060X6-64PE-B, Arista-7060X6-16PE-384C-B]: Initialize SmartSAF #23908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update the BCM config files for Arista-7060X6-64PE-B, Arista-7060X6-16PE-384C-B to initialize SmartSAF functionality.
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
.../arista/x86_64-arista_7060x6_64pe_b/Arista-7060X6-64PE-B-C448O16/th5-a7060x6-64pe.config.bcm
Show resolved
Hide resolved
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Don't initialize SmartSAF functionality for the Arista-7060X6-64PE-B-C448O16 and Arista-7060X6-64PE-B-C512S2 HWSKUs at this time.
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
device/arista/x86_64-arista_7060x6_64pe_b/Arista-7060X6-64PE-B-P64/th5-a7060x6-64pe.config.bcm
Show resolved
Hide resolved
|
Hi @ccroy-arista, can you share a csp for me to pick up some context? Thanks |
| SAI_INIT_CONFIG_FILE=/usr/share/sonic/hwsku/th5-a7060x6-16pe-384c.config.bcm | ||
| SAI_NUM_ECMP_MEMBERS=128 | ||
| SAI_NHG_HIERARCHICAL_NEXTHOP=false | ||
| SAI_SWITCH_SWITCHING_MODE_CUT_THROUGH=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why CUT_THROUGH is enabled? Is that expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this cause packet with CRC being propagated to neigh devices?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why
CUT_THROUGHis enabled? Is that expected?
I've raised this question with Broadcom, waiting on their response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A follow up question, do we have test to ensure CRC error is not propagated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Response received from Broadcom; sai.profile changes removed.
device/arista/x86_64-arista_7060x6_64pe_b/Arista-7060X6-64PE-B-P32O64/sai.profile
Outdated
Show resolved
Hide resolved
Initialize SmartSAF functionality for the Arista-7060X6-64PE-B-C448O16 and Arista-7060X6-64PE-B-C512S2 HWSKUs.
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Remove SAI_SWITCH_SWITCHING_MODE_CUT_THROUGH=true in the sai.profile files for Arista-7060X6-64PE-B, Arista-7060X6-16PE-384C-B, as this setting is not used for smartSAF.
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Cherry-pick to 202505: #24039 |
|
Cherry-pick to 202412: Azure/sonic-buildimage-msft#1637 |
From PR: sonic-net#23908
Note: this is a manual backport to 202505 for sonic-net#23908 #### Why I did it To enable the SmartSAF feature on the targer platforms. ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Added SmartSAF settings to the Broadcom config/SAI profile files. #### How to verify it From the DUT's CLI, enter the Broadcom shell: `bcmsh` Run `ps` and confirm that the cut thru mode for the desired interfaces is `Smart`. Can also confirm `SMART_STORE_AND_FORWARD=1` by running: `bsh -c "lt traverse -l TM_SMART_STORE_AND_FORWARD_CONFIG"` #### Which release branch to backport (provide reason below if selected) - [ ] 202205 - [ ] 202211 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [x] 202505 #### Tested branch (Please provide the tested image version) 202412, 202505 #### Description for the changelog Update the BCM config files for Arista-7060X6-64PE-B, Arista-7060X6-16PE-384C-B to initialize SmartSAF functionality.
#24044) Note: this is a manual backport to 202505 for #23908 #### Why I did it To enable the SmartSAF feature on the targer platforms. ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Added SmartSAF settings to the Broadcom config/SAI profile files. #### How to verify it From the DUT's CLI, enter the Broadcom shell: `bcmsh` Run `ps` and confirm that the cut thru mode for the desired interfaces is `Smart`. Can also confirm `SMART_STORE_AND_FORWARD=1` by running: `bsh -c "lt traverse -l TM_SMART_STORE_AND_FORWARD_CONFIG"` #### Which release branch to backport (provide reason below if selected) - [ ] 202205 - [ ] 202211 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [x] 202505 #### Tested branch (Please provide the tested image version) 202412, 202505 #### Description for the changelog Update the BCM config files for Arista-7060X6-64PE-B, Arista-7060X6-16PE-384C-B to initialize SmartSAF functionality.
#1637) Note: this is a manual backport to msft-202412 for sonic-net/sonic-buildimage#23908 #### Why I did it To enable the SmartSAF feature on the targer platforms. ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Added SmartSAF settings to the Broadcom config/SAI profile files. #### How to verify it From the DUT's CLI, enter the Broadcom shell: `bcmsh` Run `ps` and confirm that the cut thru mode for the desired interfaces is `Smart`. Can also confirm `SMART_STORE_AND_FORWARD=1` by running: `bsh -c "lt traverse -l TM_SMART_STORE_AND_FORWARD_CONFIG"` #### Which release branch to backport (provide reason below if selected) - [ ] 202205 - [ ] 202211 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [x] 202412 #### Tested branch (Please provide the tested image version) 202412, 202505 #### Description for the changelog Update the BCM config files for Arista-7060X6-64PE-B, Arista-7060X6-16PE-384C-B to initialize SmartSAF functionality.
#1637) Note: this is a manual backport to msft-202412 for sonic-net/sonic-buildimage#23908 #### Why I did it To enable the SmartSAF feature on the targer platforms. ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Added SmartSAF settings to the Broadcom config/SAI profile files. #### How to verify it From the DUT's CLI, enter the Broadcom shell: `bcmsh` Run `ps` and confirm that the cut thru mode for the desired interfaces is `Smart`. Can also confirm `SMART_STORE_AND_FORWARD=1` by running: `bsh -c "lt traverse -l TM_SMART_STORE_AND_FORWARD_CONFIG"` #### Which release branch to backport (provide reason below if selected) - [ ] 202205 - [ ] 202211 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [x] 202412 #### Tested branch (Please provide the tested image version) 202412, 202505 #### Description for the changelog Update the BCM config files for Arista-7060X6-64PE-B, Arista-7060X6-16PE-384C-B to initialize SmartSAF functionality.
Changes missing from msft_202503: sonic-net/sonic-buildimage#23908 sonic-net/sonic-buildimage#23722
Changes missing from msft_202503: sonic-net/sonic-buildimage#23908 sonic-net/sonic-buildimage#23722 Was already added for Arista-7060X6-64PE-B-O128 in #1674 <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md ** Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it #### How to verify it <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
sonic-net#23908) [Arista-7060X6-64PE-B, Arista-7060X6-16PE-384C-B]: Initialize SmartSAF Signed-off-by: Feng Pan <fenpan@microsoft.com>
Why I did it
To enable the SmartSAF feature on the targer platforms.
Work item tracking
How I did it
Added SmartSAF settings to the Broadcom config/SAI profile files.
How to verify it
From the DUT's CLI, enter the Broadcom shell:
bcmshRun
psand confirm that the cut thru mode for the desired interfaces isSmart.Can also confirm
SMART_STORE_AND_FORWARD=1by running:bsh -c "lt traverse -l TM_SMART_STORE_AND_FORWARD_CONFIG"Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
202412, 202505
Description for the changelog
Update the BCM config files for Arista-7060X6-64PE-B, Arista-7060X6-16PE-384C-B to initialize SmartSAF functionality.