Skip to content

fix: resolve April 2026 docker-ptf security vulnerabilities#26676

Merged
yejianquan merged 1 commit intosonic-net:masterfrom
auspham:austinpham/36979761-resolve-april-docker-ptf-vulnerability
Apr 16, 2026
Merged

fix: resolve April 2026 docker-ptf security vulnerabilities#26676
yejianquan merged 1 commit intosonic-net:masterfrom
auspham:austinpham/36979761-resolve-april-docker-ptf-vulnerability

Conversation

@auspham
Copy link
Copy Markdown
Contributor

@auspham auspham commented Apr 9, 2026

Why I did it

Attempt to fix new docker-ptf security vulnerability as of 04/2026

This pull request updates the dockers/docker-ptf/Dockerfile.j2 to incorporate several dependency upgrades and security improvements. The main focus is on updating Go and related dependencies to address vulnerabilities and ensure compatibility with the latest features and fixes.

Dependency and version updates:

  • Upgraded the Go version used in the Docker image from 1.25.8 to 1.25.9 for improved stability and security.
  • Updated the go.opentelemetry.io/otel/sdk dependency from version v1.40.0 to v1.43.0 for the gnmic build process.
  • Added or updated the github.com/go-jose/go-jose/v4 dependency to version v4.1.4 in the build steps for grpcurl, gnoic, and gnmic to ensure consistent cryptography support. [1] [2] [3]
  • Added the latest versions of github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream and github.com/aws/aws-sdk-go-v2/service/s3 as dependencies for the gnmic build.

Security improvements:

  • Included a system package upgrade step to address vulnerabilities such as CVE-2026-33416 and CVE-2026-33636 (affecting libpng16-16), among others.
Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Copilot AI review requested due to automatic review settings April 9, 2026 11:17
@auspham auspham requested a review from lguohan as a code owner April 9, 2026 11:17
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Apr 9, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: auspham / name: Austin Pham (e60cdf2)
  • ✅ login: Copilot / name: Copilot (e60cdf2)

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the docker-ptf container build to remediate newly reported April 2026 security findings by upgrading the Go toolchain and several Go module dependencies used to build included utilities.

Changes:

  • Bump Go toolchain used during image build from 1.25.8 to 1.25.9.
  • Add/update Go module dependencies for grpcurl/gnoic/gnmic builds (notably go-jose/v4 and otel/sdk).
  • Add an additional OS package upgrade step and pull in AWS SDK modules for gnmic.

Comment thread dockers/docker-ptf/Dockerfile.j2
Comment thread dockers/docker-ptf/Dockerfile.j2
@auspham auspham force-pushed the austinpham/36979761-resolve-april-docker-ptf-vulnerability branch from 13f390b to 86d2223 Compare April 9, 2026 14:10
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham force-pushed the austinpham/36979761-resolve-april-docker-ptf-vulnerability branch from 86d2223 to cf7438e Compare April 9, 2026 14:13
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copilot AI review requested due to automatic review settings April 9, 2026 14:28
@auspham auspham force-pushed the austinpham/36979761-resolve-april-docker-ptf-vulnerability branch from cf7438e to 2ca0308 Compare April 9, 2026 14:28
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@auspham auspham force-pushed the austinpham/36979761-resolve-april-docker-ptf-vulnerability branch from 2ca0308 to 6c3af36 Compare April 9, 2026 14:39
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copilot AI review requested due to automatic review settings April 9, 2026 14:53
@auspham auspham force-pushed the austinpham/36979761-resolve-april-docker-ptf-vulnerability branch from 6c3af36 to cddd862 Compare April 9, 2026 14:53
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread dockers/docker-ptf/Dockerfile.j2 Outdated
Comment thread dockers/docker-ptf/Dockerfile.j2
@auspham auspham force-pushed the austinpham/36979761-resolve-april-docker-ptf-vulnerability branch from cddd862 to c4d2f46 Compare April 9, 2026 15:06
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@auspham
Copy link
Copy Markdown
Contributor Author

auspham commented Apr 13, 2026

Influxdb is new dependency introduced by #26146

gnoic and grpcurl are fixable cc @wangxin @Janetxxx could i please have approval. Thanks

@auspham
Copy link
Copy Markdown
Contributor Author

auspham commented Apr 13, 2026

Discussed with @Janetxxx, Janet will raise a PR to migrate influxdb to 3.x

Copilot AI review requested due to automatic review settings April 14, 2026 00:30
@auspham auspham force-pushed the austinpham/36979761-resolve-april-docker-ptf-vulnerability branch from 5dfdbb9 to 950ccb1 Compare April 14, 2026 00:30
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham force-pushed the austinpham/36979761-resolve-april-docker-ptf-vulnerability branch from 950ccb1 to 7b452c3 Compare April 14, 2026 00:33
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment thread dockers/docker-ptf/Dockerfile.j2 Outdated
Comment thread dockers/docker-ptf/Dockerfile.j2 Outdated
Comment thread dockers/docker-ptf/Dockerfile.j2 Outdated
- Upgrade Go toolchain 1.25.8 → 1.25.9 (fixes CVE-2026-32280 through
  CVE-2026-32289: stdlib crypto/tls, archive/tar, html/template, os)
- Bump go.opentelemetry.io/otel/sdk v1.40.0 → v1.43.0 in gnmic
  (CVE-2026-39883: PATH hijacking via BSD kenv)
- Add github.com/go-jose/go-jose/v4@v4.1.4 to gnmic, gnoic, grpcurl
  (CVE-2026-34986: DoS via crafted JSON Web Encryption)
- Bump github.com/docker/docker to latest in gnmic
  (CVE-2026-34040: authorization bypass, CVE-2026-33997: privilege
  validation bypass during plugin installation)
- Add aws-sdk-go-v2 eventstream/s3 latest to gnmic
  (GHSA-xmrv-pmrh-hhx2: DoS via panic in AWS SDK for Go v2)
- Existing apt-get upgrade covers libpng16-16 fix
  (CVE-2026-33416: use-after-free, CVE-2026-33636: OOB read/write)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Ubuntu <austinpham@austinpham-dev-vm-2.d4y3nv5wwgfelhhopdxv1tqjld.dx.internal.cloudapp.net>
Signed-off-by: Austin Pham (agent) <austinpham@microsoft.com>
@auspham auspham force-pushed the austinpham/36979761-resolve-april-docker-ptf-vulnerability branch from 7b452c3 to e60cdf2 Compare April 14, 2026 02:14
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@yejianquan yejianquan merged commit e44fc72 into sonic-net:master Apr 16, 2026
23 checks passed
auspham added a commit to auspham/sonic-buildimage that referenced this pull request Apr 16, 2026
Cherry-pick e60cdf2 to bring Go 1.25.9, go-jose/v4, otel/sdk,
aws-sdk-go-v2/s3 upgrades and gocloud-patches to 202411 branch.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Austin Pham (agent) <austinpham@microsoft.com>
auspham added a commit to auspham/sonic-buildimage that referenced this pull request Apr 16, 2026
Cherry-pick e60cdf2 to bring Go 1.25.9, go-jose/v4, otel/sdk,
aws-sdk-go-v2/s3 upgrades and gocloud-patches to 202411 branch.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Austin Pham (agent) <austinpham@microsoft.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202511: #26866

auspham added a commit to auspham/sonic-buildimage that referenced this pull request Apr 20, 2026
Cherry-pick e60cdf2 to bring Go 1.25.9, go-jose/v4, otel/sdk,
aws-sdk-go-v2/s3 upgrades and gocloud-patches to 202411 branch.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Austin Pham (agent) <austinpham@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants