fix: polish switcher overlay spacing and glass - #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NSGlassEffectViewon macOS 26 and native popover material on macOS 14–15.Test Coverage
Tests: 33 → 33 test files (+0); one directional-padding regression test added.
Pre-Landing Review
No issues found.
Design Review
Design Review (lite): 0 findings. AI Slop: clean.
Eval Results
No prompt-related files changed — evals skipped.
Scope Drift
Scope Check: CLEAN. The diff is limited to approved overlay spacing, caption alignment, native glass, tests, and their design/implementation records.
Plan Completion
4 tasks complete, 0 partial, 0 not done. Live Debug overlay inspection was attempted but blocked by macOS Accessibility and Screen Recording permissions for the Debug bundle, as permitted by the verification plan.
Verification Results
swift buildswift test— 19 tests, 0 failuresBUILD SUCCEEDEDgit diff --check origin/main...HEADDocumentation
README and project context remain accurate. Approved visual behavior is documented in the design and implementation plan included in this PR.
Test plan