fix: rebalance switcher focus insets - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Coverage
Coverage gate: PASS at the 80% target. The two native-macOS visual flows were verified in the signed local Debug app and approved before release.
Pre-Landing Review
Clean. Review found two medium layout-test issues; both were fixed and the final re-review returned APPROVE with no blockers.
Design Review
Manual visual QA passed for both application and current-app window switchers using the signed local Debug build.
Eval Results
No prompt-related files changed; evals skipped.
Scope Drift
Scope Check: CLEAN. The diff is limited to switcher focus geometry, its tests, and the matching design/implementation documentation.
Plan Completion
All 8 plan items are complete. Final approved values are aligned across code, tests, and docs; no items are deferred or unverifiable.
Verification Results
git diff --check: cleanDocumentation
Test plan