Windows RDS crashes when many devices connect - #454
Merged
Conversation
lo-simon
changed the title
lo-simon
marked this pull request as draft
July 19, 2025 21:58
Co-authored-by: jonathan-r-thorpe <64410119+jonathan-r-thorpe@users.noreply.github.com>
Co-authored-by: jonathan-r-thorpe <64410119+jonathan-r-thorpe@users.noreply.github.com>
lo-simon
marked this pull request as ready for review
September 30, 2025 09:59
jonathan-r-thorpe
force-pushed
the
fix_heavy_registration
branch
from
October 17, 2025 11:09
9de55c6 to
a5ab729
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Windows, there is a maximum number of exclusive locks that can be held. Once it reaches the maximum value, the lock will throw a lock exception. Although the registration API can handle the exception, many of the nmos-cpp threads, such as
send_events_ws_messages_threadanderase_expired_events_resources_thread, do not handle the lock exception when the reserve_lock_guard is out of scope, which would cause RDS to crash. To resolve this issue, it is essential to ensure that the exception is handled correctly.