Skip to content

Bump golangci-linter to 1.62.2 #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sosedoff merged 2 commits into from
Nov 11, 2025
+7 −5
Merged

Bump golangci-linter to 1.62.2 #772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b21c9a5
Bump golangci-linter to 1.62.2
sosedoff Dec 15, 2024
9f5bfda
Address linting warning via change or ignore
sosedoff Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
version: v1.57.1
version: v1.62.2

fmt:
name: fmt
Expand Down
4 changes: 3 additions & 1 deletion pkg/client/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ func assertMatches(t *testing.T, expected, src []string) {

func pgVersion() (int, int) {
var major, minor int
fmt.Sscanf(os.Getenv("PGVERSION"), "%d.%d", &major, &minor)
if _, err := fmt.Sscanf(os.Getenv("PGVERSION"), "%d.%d", &major, &minor); err != nil {
log.Println("[warn] unable to read value of PGVERSION env var")
}
return major, minor
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/client/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ var (
// Example: 10.2.3.1 -> 10.2
func getMajorMinorVersion(str string) (major int, minor int) {
chunks := strings.Split(str, ".")
fmt.Sscanf(chunks[0], "%d", &major)
fmt.Sscanf(chunks[0], "%d", &major) //nolint
if len(chunks) > 1 {
fmt.Sscanf(chunks[1], "%d", &minor)
fmt.Sscanf(chunks[1], "%d", &minor) //nolint
}
return
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/connection/connection_string.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ func lookupPassword(opts command.Options, url *neturl.URL) string {

if url != nil {
var dbName string
fmt.Sscanf(url.Path, "/%s", &dbName)
fmt.Sscanf(url.Path, "/%s", &dbName) //nolint

return passfile.FindPassword(
url.Hostname(),
Expand Down
Loading