Ensure that timezone TZ env var is unmodified by django.setup() - #284
Merged
Conversation
javierggt
reviewed
Apr 5, 2023
Contributor
There was a problem hiding this comment.
We could merge it as is, but perhaps it would be good to have a test for this somewhere?
I tested using this:
imoprt os
import datetime
os.environ["TZ"] = "UTC" # optional
dt = datetime.datetime(2020, 11, 1, 1)
dt1 = dt.astimezone()
import kadi.events
kadi.events.eclipses
dt2 = dt.astimezone().astimezone()
assert dt1 == dt2
javierggt
approved these changes
Apr 5, 2023
This was referenced Jun 1, 2023
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes the issue described in #283, but instead by ensuring that the
TZenvironment variable is not modified by the call todjango.setup(). For most unix machines this means thatTZwill be undefined, but on GRETA it will remain asGMT.Interface impacts
None
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
These tests use sot/cxotime#36.
Test 1 (no TZ defined)
Test 2 (TZ=GMT)