Skip to content

Fix mobile Stepper Run evaluator - #4263

Open
Guflly wants to merge 1 commit into
source-academy:masterfrom
Guflly:fix/mobile-stepper-run
Open

Fix mobile Stepper Run evaluator#4263
Guflly wants to merge 1 commit into
source-academy:masterfrom
Guflly:fix/mobile-stepper-run

Conversation

@Guflly

@Guflly Guflly commented Aug 8, 2026

Copy link
Copy Markdown

Description

Keeps the Conductor Stepper tab selected when mobile Run is pressed, so execution continues with the Stepper evaluator.

Fixes #4262.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

  • yarn test src/commons/sideContent/SideContentHelper.test.tsx
  • yarn test
  • yarn run tsc
  • yarn lint
  • yarn build

Checklist

  • I have tested this code

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5642d2b5-1322-4218-a18b-a41b4ef955ee

📥 Commits

Reviewing files that changed from the base of the PR and between 50886d3 and c70a543.

📒 Files selected for processing (2)
  • src/commons/sideContent/SideContentHelper.test.tsx
  • src/commons/sideContent/SideContentHelper.ts

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved side-content navigation for mobile Run selections.
    • Preserved the Conductor Stepper selection when switching tabs, preventing unintended navigation.
  • Tests
    • Added coverage for tab switching behavior in both Conductor Stepper and regular tab contexts.

Walkthrough

The change updates useSideContent to preserve the conductor stepper selection when mobile Run is selected. New Redux-backed tests cover both the blocked transition and the regular-tab dispatch path.

Changes

Side-content navigation

Layer / File(s) Summary
Mobile Run navigation guard and coverage
src/commons/sideContent/SideContentHelper.ts, src/commons/sideContent/SideContentHelper.test.tsx
The navigation guard blocks mobileEditorRun when CONDUCTOR_STEPPER_TAB_ID is selected. Tests verify no dispatch for the conductor stepper and the expected dispatch from a regular tab.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the mobile Stepper Run evaluator fix.
Description check ✅ Passed The description states the fix, linked issue, bug-fix type, test commands, and completed testing checklist.
Linked Issues check ✅ Passed The code preserves the Conductor Stepper tab during mobile Run, which ensures the Stepper evaluator is used for issue #4262.
Out of Scope Changes check ✅ Passed The implementation and tests directly address the mobile Stepper Run behavior without unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile mode: stepper not working

1 participant