Skip to content

Fix Source Module names to singular form and API documentation bugfixes - #61

Merged
MarcusTXK merged 2 commits into
masterfrom
modules/documentation
May 1, 2021
Merged

Fix Source Module names to singular form and API documentation bugfixes#61
MarcusTXK merged 2 commits into
masterfrom
modules/documentation

Conversation

@Anonymxtrix

Copy link
Copy Markdown
Contributor

Description

Fix Source Module names to singular form for curve, sound and stereo_sounds library and API documentation bugfixes.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@MarcusTXK MarcusTXK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@MarcusTXK
MarcusTXK merged commit 091626d into master May 1, 2021
@Cloud7050
Cloud7050 deleted the modules/documentation branch November 1, 2023 00:16
Akshay-2007-1 added a commit that referenced this pull request Jul 30, 2026
…rors

- bump @sourceacademy/conductor catalog pin to ^0.8.2, the version that
  actually contains the sync fast-path fixes (conductor#54/#61)
- restore range/integer validation on set_dimensions, set_fps and
  set_loop_count, matching pre-migration behavior (these previously threw
  a student-facing error on invalid input, the migration silently dropped
  it instead)
- report a filter's runtime error through conductor's error channel, not
  just console.error, so a student sees why their filter reverted to the
  default copy filter instead of getting no feedback at all
- remove unused PIX_N_FLIX_TAB_NAME export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants