chore(web): resolve outstanding ESLint warnings - #1537
Conversation
Clears the four warnings reported by `yarn lint` so the lint run is clean: - Remove unused `Session` import from searchResultsPage.tsx - Remove unused `sourcebot_diff_refs` import from gitlabPushMrReviews.test.ts - Add the stable `setHoveredReference`/`setSelectedReference` callbacks to the effect dependency array in chatThreadListItem.tsx. Both are `useCallback(..., [])`, so the effect's re-run behavior is unchanged. - Suppress `@next/next/no-img-element` for the MCP favicon, matching the existing convention for remote images elsewhere in the codebase. Also normalizes tab indentation to spaces on the root `lint:fix` script line. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 3 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
License Audit
Weak Copyleft Packages (informational)
Resolved Packages (8)
|
Clears the four warnings reported by
yarn lintso the lint run comes back clean.Changes
searchResultsPage.tsx@typescript-eslint/no-unused-varsSessionimportgitlabPushMrReviews.test.ts@typescript-eslint/no-unused-varssourcebot_diff_refsimportchatThreadListItem.tsxreact-hooks/exhaustive-depssetHoveredReference/setSelectedReferenceto the dep arraymcpFavicon.tsx@next/next/no-img-elementeslint-disable-next-linewith a justification commentAlso normalizes tab indentation to spaces on the root
lint:fixscript line.Notes
chatThreadListItem.tsx. Both setters areuseCallback(..., []), so their identities are stable for the lifetime of the component. Adding them to the dep array satisfies the rule without changing when the effect re-runs.mcpFavicon.tsxkeeps<img>deliberately. Favicons come from arbitrary MCP server domains, so routing them through thenext/imageoptimizer isn't a good fit. This matches the existing convention for remote images elsewhere in the codebase (mcpToolPermissionsPage.tsx,changelogEntryDialog.tsx,attachmentTray.tsx, and others).yarn lint:fixleft them in place:no-unused-varsandno-img-elementship no fixer, andexhaustive-depsexposes its fix as an editor suggestion only (suggestions are never applied by--fix).Verification
yarn lintpasses with zero problems.vitest run gitlabPushMrReviews.test.ts-> 14/14 passing.tsc --noEmiterror count is unchanged vs.main(30 pre-existing errors, none in the touched files); verified by diffing against a stashed baseline.🤖 Generated with Claude Code
Note
Low Risk
Lint-only edits with no security, data, or behavioral intent; the hook-deps change is low risk because the added dependencies are stable callbacks.
Overview
Clears the remaining ESLint warnings so
yarn lintruns with zero problems. There is no intended product or runtime behavior change.Unused imports are removed from
searchResultsPage.tsx(Session) andgitlabPushMrReviews.test.ts(sourcebot_diff_refs). InchatThreadListItem.tsx,setHoveredReferenceandsetSelectedReferenceare added to auseEffectdependency array to satisfyreact-hooks/exhaustive-deps; both setters are stableuseCallbackhooks, so effect timing should stay the same.mcpFavicon.tsxkeeps a plainimgfor remote MCP favicons with aneslint-disable-next-lineand comment, matching other remote-image cases in the web package. Rootpackage.jsononly normalizes indentation on thelint:fixscript line.Reviewed by Cursor Bugbot for commit 7a44a5a. Bugbot is set up for automated code reviews on this repo. Configure here.