Skip to content

chore(web): resolve outstanding ESLint warnings - #1537

Merged
brendan-kellam merged 4 commits into
mainfrom
brendan/fix-lint-warnings
Aug 5, 2026
Merged

chore(web): resolve outstanding ESLint warnings#1537
brendan-kellam merged 4 commits into
mainfrom
brendan/fix-lint-warnings

Conversation

@brendan-kellam

@brendan-kellam brendan-kellam commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Clears the four warnings reported by yarn lint so the lint run comes back clean.

Changes

File Rule Fix
searchResultsPage.tsx @typescript-eslint/no-unused-vars Removed unused Session import
gitlabPushMrReviews.test.ts @typescript-eslint/no-unused-vars Removed unused sourcebot_diff_refs import
chatThreadListItem.tsx react-hooks/exhaustive-deps Added setHoveredReference / setSelectedReference to the dep array
mcpFavicon.tsx @next/next/no-img-element eslint-disable-next-line with a justification comment

Also normalizes tab indentation to spaces on the root lint:fix script line.

Notes

  • No behavior change in chatThreadListItem.tsx. Both setters are useCallback(..., []), so their identities are stable for the lifetime of the component. Adding them to the dep array satisfies the rule without changing when the effect re-runs.
  • mcpFavicon.tsx keeps <img> deliberately. Favicons come from arbitrary MCP server domains, so routing them through the next/image optimizer isn't a good fit. This matches the existing convention for remote images elsewhere in the codebase (mcpToolPermissionsPage.tsx, changelogEntryDialog.tsx, attachmentTray.tsx, and others).
  • None of these warnings were auto-fixable, which is why yarn lint:fix left them in place: no-unused-vars and no-img-element ship no fixer, and exhaustive-deps exposes its fix as an editor suggestion only (suggestions are never applied by --fix).

Verification

  • yarn lint passes with zero problems.
  • vitest run gitlabPushMrReviews.test.ts -> 14/14 passing.
  • tsc --noEmit error count is unchanged vs. main (30 pre-existing errors, none in the touched files); verified by diffing against a stashed baseline.

🤖 Generated with Claude Code


Note

Low Risk
Lint-only edits with no security, data, or behavioral intent; the hook-deps change is low risk because the added dependencies are stable callbacks.

Overview
Clears the remaining ESLint warnings so yarn lint runs with zero problems. There is no intended product or runtime behavior change.

Unused imports are removed from searchResultsPage.tsx (Session) and gitlabPushMrReviews.test.ts (sourcebot_diff_refs). In chatThreadListItem.tsx, setHoveredReference and setSelectedReference are added to a useEffect dependency array to satisfy react-hooks/exhaustive-deps; both setters are stable useCallback hooks, so effect timing should stay the same. mcpFavicon.tsx keeps a plain img for remote MCP favicons with an eslint-disable-next-line and comment, matching other remote-image cases in the web package. Root package.json only normalizes indentation on the lint:fix script line.

Reviewed by Cursor Bugbot for commit 7a44a5a. Bugbot is set up for automated code reviews on this repo. Configure here.

Clears the four warnings reported by `yarn lint` so the lint run is clean:

- Remove unused `Session` import from searchResultsPage.tsx
- Remove unused `sourcebot_diff_refs` import from gitlabPushMrReviews.test.ts
- Add the stable `setHoveredReference`/`setSelectedReference` callbacks to the
  effect dependency array in chatThreadListItem.tsx. Both are `useCallback(..., [])`,
  so the effect's re-run behavior is unchanged.
- Suppress `@next/next/no-img-element` for the MCP favicon, matching the existing
  convention for remote images elsewhere in the codebase.

Also normalizes tab indentation to spaces on the root `lint:fix` script line.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actions

This comment has been minimized.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@brendan-kellam, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 3 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3f42eb65-ba33-4632-b2a6-030738227194

📥 Commits

Reviewing files that changed from the base of the PR and between 895040a and 7a44a5a.

📒 Files selected for processing (5)
  • package.json
  • packages/web/src/app/(app)/search/components/searchResultsPage.tsx
  • packages/web/src/ee/features/chat/components/chatThread/chatThreadListItem.tsx
  • packages/web/src/ee/features/chat/mcp/components/mcpFavicon.tsx
  • packages/web/src/features/agents/review-agent/nodes/gitlabPushMrReviews.test.ts
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch brendan/fix-lint-warnings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@brendan-kellam
brendan-kellam merged commit f88c56a into main Aug 5, 2026
14 checks passed
@brendan-kellam
brendan-kellam deleted the brendan/fix-lint-warnings branch August 5, 2026 00:40
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

License Audit

⚠️ Status: PASS

Metric Count
Total packages 2200
Resolved (non-standard) 8
Unresolved 0
Strong copyleft 0
Weak copyleft 28

Weak Copyleft Packages (informational)

Package Version License
@img/sharp-libvips-darwin-arm64 1.3.2 LGPL-3.0-or-later
@img/sharp-libvips-darwin-x64 1.3.2 LGPL-3.0-or-later
@img/sharp-libvips-linux-arm 1.3.2 LGPL-3.0-or-later
@img/sharp-libvips-linux-arm64 1.3.2 LGPL-3.0-or-later
@img/sharp-libvips-linux-ppc64 1.3.2 LGPL-3.0-or-later
@img/sharp-libvips-linux-riscv64 1.3.2 LGPL-3.0-or-later
@img/sharp-libvips-linux-s390x 1.3.2 LGPL-3.0-or-later
@img/sharp-libvips-linux-x64 1.3.2 LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-arm64 1.3.2 LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-x64 1.3.2 LGPL-3.0-or-later
@img/sharp-wasm32 0.35.3 Apache-2.0 AND LGPL-3.0-or-later AND MIT
@img/sharp-win32-arm64 0.35.3 Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-ia32 0.35.3 Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-x64 0.35.3 Apache-2.0 AND LGPL-3.0-or-later
axe-core 4.10.3 MPL-2.0
dompurify 3.4.12 (MPL-2.0 OR Apache-2.0)
lightningcss 1.32.0 MPL-2.0
lightningcss-android-arm64 1.32.0 MPL-2.0
lightningcss-darwin-arm64 1.32.0 MPL-2.0
lightningcss-darwin-x64 1.32.0 MPL-2.0
lightningcss-freebsd-x64 1.32.0 MPL-2.0
lightningcss-linux-arm-gnueabihf 1.32.0 MPL-2.0
lightningcss-linux-arm64-gnu 1.32.0 MPL-2.0
lightningcss-linux-arm64-musl 1.32.0 MPL-2.0
lightningcss-linux-x64-gnu 1.32.0 MPL-2.0
lightningcss-linux-x64-musl 1.32.0 MPL-2.0
lightningcss-win32-arm64-msvc 1.32.0 MPL-2.0
lightningcss-win32-x64-msvc 1.32.0 MPL-2.0
Resolved Packages (8)
Package Version Original Resolved Source
codemirror-lang-elixir 4.0.0 UNKNOWN Apache-2.0 published package LICENSE file (full Apache License 2.0 text); no license field in package.json
khroma 2.1.0 UNKNOWN MIT published package LICENSE file ('The MIT License (MIT)', (c) Fabio Spampinato); npm registry metadata has no license field
lezer-elixir 1.1.2 UNKNOWN Apache-2.0 published package LICENSE file (full Apache License 2.0 text); no license field in package.json
map-stream 0.1.0 UNKNOWN MIT published package LICENCE file (verbatim MIT text, (c) 2011 Dominic Tarr)
memorystream 0.3.1 UNKNOWN MIT extracted from object: package.json 'licenses' array [{type: MIT, url: ...}]; confirmed by LICENSE file (verbatim MIT text)
pause-stream 0.0.11 MIT,Apache2 (MIT OR Apache-2.0) extracted from object: package.json license array ['MIT','Apache2']; confirmed by LICENSE file header 'Dual Licensed MIT and Apache 2'
posthog-js 1.369.0 SEE LICENSE IN LICENSE Apache-2.0 published package LICENSE file: Apache License 2.0 ((c) 2020 PostHog/Hiberly, (c) 2015 Mixpanel); trailing MIT notices apply only to vendored third-party snippets
valid-url 1.0.9 UNKNOWN MIT published package LICENSE file (verbatim MIT text, (c) 2013 Odysseas Tsatalos and oDesk Corporation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant