Create dedicated simulator section #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort inner pages alphabetically, and top level ones by importance. Weights are now also sequential
That's an extra
Dasepho
reviewed
Aug 11, 2021
Dasepho
reviewed
Aug 11, 2021
Dasepho
reviewed
Aug 11, 2021
Dasepho
reviewed
Aug 11, 2021
Dasepho
reviewed
Aug 11, 2021
Dasepho
reviewed
Aug 11, 2021
Dasepho
left a comment
Dasepho
left a comment
There was a problem hiding this comment.
some naming things to check, looks like some SR naming conventions. I don't know which are overlap and which differ
tpoomlmly
previously requested changes
Aug 13, 2021
Member
tpoomlmly
left a comment
tpoomlmly
left a comment
There was a problem hiding this comment.
We should also include docs on the IO that the simulated arduino has
Co-authored-by: Tommy Poll <Tommy@poolle.co.uk>
Co-authored-by: Tommy Poll <Tommy@poolle.co.uk>
tpoomlmly
reviewed
Aug 13, 2021
Member
|
Moving the simulator page broke a link on the kit page |
tpoomlmly
requested changes
Aug 15, 2021
Co-authored-by: Tommy Poll <Tommy@poolle.co.uk>
tpoomlmly
previously approved these changes
Aug 16, 2021
Montinje
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers bits of #154