Skip to content

refactor(chore): remove Node js 20 support#30

Merged
yeshamavani merged 1 commit into
masterfrom
GH-29
Jun 16, 2026
Merged

refactor(chore): remove Node js 20 support#30
yeshamavani merged 1 commit into
masterfrom
GH-29

Conversation

@Sourav-kashyap

Copy link
Copy Markdown
Contributor

remove Node js 20 support

BREAKING CHANGE:
yes

GH-29

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine

Build:

Screenshot 2026-06-11 at 3 04 03 PM

Test:

Screenshot 2026-06-11 at 3 04 17 PM

@Sourav-kashyap Sourav-kashyap self-assigned this Jun 11, 2026
@Sourav-kashyap Sourav-kashyap linked an issue Jun 11, 2026 that may be closed by this pull request

@rohit-sourcefuse rohit-sourcefuse left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 20 removal and the workflow/matrix changes look clean. One thing to fix before merge: package.json sets engines.node to "22 || 24", but the regenerated package-lock.json root still has ">=22" — the lockfile was generated before the engines value was changed and not re-run. Re-run npm install so they match.

Suggestion: standardize on ">=22" for a published library — "22 || 24" excludes Node 23 and every future LTS (26, 28…), so the package would refuse to install on the next LTS until another bump. Don't over-constrain consumers. Checks are green otherwise.

Also (pre-existing, optional): this workflow still pins actions/checkout@v3 + setup-node@v3 while the other repos in this batch use @v4 — worth bumping to v4 while you're here.

remove Node js 20 support

BREAKING CHANGE:
yes

GH-29
@sonarqubecloud

Copy link
Copy Markdown

SonarQube reviewer guide

Summary: Drops support for Node.js 20 and targets Node.js 22 and 24 only, along with dependency updates.

Review Focus:

  • Node.js engine constraint change from >=20 to 22 || 24 is a breaking change that removes support for Node 20
  • Version bump from 2.0.0 to 2.1.0 may not reflect the breaking nature of this change (should typically be 3.0.0)
  • Extensive dependency updates across Babel, LoopBack, and other packages - verify compatibility

Start review at: package.json. This file contains the critical engine version constraint change and version number, which define the project's Node.js compatibility and semantic versioning implications. The restricted engine requirement is a significant breaking change that should be clearly communicated.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rohit-sourcefuse rohit-sourcefuse left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Engines fix looks good and checks are green — approving. The checkout@v3 / setup-node@v3@v4 bump is optional and pre-existing, fine to leave for a follow-up.

@yeshamavani
yeshamavani merged commit 3dc7642 into master Jun 16, 2026
6 checks passed
@yeshamavani

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove Node.js 20 support

3 participants