This repository was archived by the owner on Sep 11, 2025. It is now read-only.
RFC 137: Document testing philosophy and owners#788
Merged
nicksnyder merged 7 commits intomasterfrom Apr 21, 2020
Merged
Conversation
lguychard
approved these changes
Apr 20, 2020
tsenart
approved these changes
Apr 20, 2020
Co-Authored-By: Loïc Guychard <loic@sourcegraph.com>
efritz
approved these changes
Apr 20, 2020
eseliger
approved these changes
Apr 20, 2020
mrnugget
approved these changes
Apr 20, 2020
attfarhan
approved these changes
Apr 20, 2020
keegancsmith
approved these changes
Apr 20, 2020
beyang
approved these changes
Apr 20, 2020
Contributor
felixfbecker
left a comment
felixfbecker
left a comment
There was a problem hiding this comment.
I like this a lot!
What do you think of adding an image of the testing pyramid somewhere, to communicate the ratios between amount of tests we're aiming for?
Co-Authored-By: Felix Becker <felix.b@outlook.com>
rvantonder
reviewed
Apr 20, 2020
Co-Authored-By: Felix Becker <felix.b@outlook.com>
Contributor
Author
Added one in 89b85a1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Action item #5 in RFC 136