-
Notifications
You must be signed in to change notification settings - Fork 569
Fix Jaeger ports for HTTP tracing #1128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Build is failing with:
Not likely a blocker for merging this fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh nice catch I remember this in helm
|
The backport to To backport this PR manually, you can either: Via the sg toolUse the sg backport -r 5.11.x -p 1128Via your terminalTo backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.11.x 5.11.x
# Navigate to the new working tree
cd .worktrees/backport-5.11.x
# Create a new branch
git switch --create backport-1128-to-5.11.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 74c9bff00e62304ba9aac231130ccd91fdad8da0
# Push it to GitHub
git push --set-upstream origin backport-1128-to-5.11.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.11.xIf you encouter conflict, first resolve the conflict and stage all files, then run the commands below: git cherry-pick --continue
# Push it to GitHub
git push --set-upstream origin backport-1128-to-5.11.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.11.x
Once the pull request has been created, please ensure the following:
|
| environment: | ||
| - JAEGER_HOST=jaeger | ||
| - JAEGER_OTLP_GRPC_PORT=4320 | ||
| - JAEGER_OTLP_HTTP_PORT=4321 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This port wasn't open, needed to open it
| "--collector.otlp.enabled", | ||
| "--collector.otlp.grpc.host-port=:4320", | ||
| "--collector.otlp.http.host-port=:4321" | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making command parameters and environment variables consistent with the Helm repo
Updating Docker repo to match the fix in the Helm repo from a few months ago, so that otel-collector is sending trace data to Jaeger on the same port that Jaeger is listening on.
Checklist
Test plan
Tested manually
docker-compose -f docker-compose.yaml -f jaeger/docker-compose.yaml -f override.yaml up -d --remove-orphans