-
Notifications
You must be signed in to change notification settings - Fork 125
add codeinsights-db (TimescaleDB) deployment #1851
Conversation
This PR adds the Code Insights TimescaleDB deployment, which will be used to store time series data for tracking insights about code. For more information on what this will be used for, see https://github.com/sourcegraph/sourcegraph/issues/17218 TimescaleDB is a plugin for Postgres which extends it to support time series data storage. We only use the OSS version, and so deploying it is always free (and their non-free version supports our use case anyway.) People deploying Sourcegraph should use this deployment and not try to deploy TimescaleDB as a plugin in their Postgres deployment for a few reasons: 1. TimescaleDB only supports specific Postgres versions, e.g. not Postgres 13 yet. 2. TimescaleDB should have isolated resources from the rest of Sourcegraph, so as to prevent Code Insights from interfering with other Sourcegraph features in general. Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
|
Note:
Questions:
|
Not a requirement as that project is parked. If you want to do it low-prio, sure! |
|
@pecigonzalo As I noted in the description, I think people should deploy this as a pod (including us on sourcegraph.com) and not as an extension in their other Postgres deployment or similar. I will see about sending docs to make this very explicit/clear. We will also only be storing the insights data here, so data loss will be minimal (just insights) should someone fail to backup the pods disks. |
|
Once I merge this, what is the process for getting this into the dot-com repo? Do I perform a |
|
@slimsag Yes, a git merge will be necessary. https://about.sourcegraph.com/handbook/engineering/deployments#merging-upstream-deploy-sourcegraph-into-deploy-sourcegraph-dot-com Amongst other things that I can think of, you'll need to make sure that the |
Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
This PR adds the Code Insights TimescaleDB deployment, which will be used to
store time series data for tracking insights about code. For more information
on what this will be used for, see https://github.com/sourcegraph/sourcegraph/issues/17218
TimescaleDB is a plugin for Postgres which extends it to support time series
data storage. We only use the OSS version, and so deploying it is always free
(and their non-free version supports our use case anyway.)
People deploying Sourcegraph should use this deployment and not try to deploy
TimescaleDB as a plugin in their Postgres deployment for a few reasons:
yet.
as to prevent Code Insights from interfering with other Sourcegraph features
in general.
Signed-off-by: Stephen Gutekanst stephen@sourcegraph.com
Checklist