output: add String() (string, error)#30
Merged
Merged
Conversation
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Closed
Merged
bobheadxi
force-pushed
the
05-20-output_add_String_string_error_
branch
from
May 20, 2022 20:49
f4273a9 to
f0b1bf4
Compare
Codecov Report
@@ Coverage Diff @@
## lift-output-and-aggregator #30 +/- ##
==============================================================
+ Coverage 69.54% 69.68% +0.14%
==============================================================
Files 8 8
Lines 348 353 +5
==============================================================
+ Hits 242 246 +4
- Misses 85 86 +1
Partials 21 21
Continue to review full report at Codecov.
|
bobheadxi
force-pushed
the
05-20-output_add_String_string_error_
branch
from
May 20, 2022 20:54
f0b1bf4 to
9f43e4b
Compare
bobheadxi
force-pushed
the
05-20-output_add_String_string_error_
branch
from
May 20, 2022 22:33
9f43e4b to
31d00ba
Compare
Member
Author
|
Merging this directly as well to clear the way for some refactors! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28 by adding a (more efficient) alias for the common pattern of getting Lines() and joining it back into a single string.